[GitHub] [geode] jujoramos commented on a change in pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

[GitBox <gi...@apache.org>]

jujoramos commented on a change in pull request #5175:
URL: https://github.com/apache/geode/pull/5175#discussion_r433815915



##########
File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java
##########
@@ -66,6 +66,7 @@
   private static final String GROUP2 = "GROUP2";
   private static final String REGION_1 = "REGION1";
   private static final String DISKSTORE = "DISKSTORE";
+  private static final String IF_FILE_EXT = ".if";

Review comment:
       No need to have this field as it already exists (with `public` modifier) within the `DiskInitFile` class.

##########
File path: geode-gfsh/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/AlterDiskStoreCommandIntegrationTest.java
##########
@@ -34,16 +37,17 @@
 
   @Rule
   public GfshParserRule gfsh = new GfshParserRule();
-
   private GfshCommand command;
+  private static final String IF_FILE_EXT = ".if";

Review comment:
       No need to have this field as it already exists (with `public` modifier) within the `DiskInitFile` class.

##########
File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsUtils.java
##########
@@ -34,6 +34,8 @@
 class DiskStoreCommandsUtils {
   private static final Logger logger = LogService.getLogger();
 
+  public static final String IF_FILE_EXT = ".if";

Review comment:
       No need to have this field as it already exists (with `public` modifier) within the `DiskInitFile` class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org