You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2017/09/08 16:08:54 UTC
[1/2] qpid-proton git commit: PROTON-1580: go: example tests failing
in URL parse
Repository: qpid-proton
Updated Branches:
refs/heads/master f773c2cff -> 7a5ded793
PROTON-1580: go: example tests failing in URL parse
Fixed invalid URL format in test driver.
Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/7a5ded79
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/7a5ded79
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/7a5ded79
Branch: refs/heads/master
Commit: 7a5ded793ef436dd1a1654345420c40926b27712
Parents: 890a9d4
Author: Alan Conway <ac...@redhat.com>
Authored: Fri Sep 8 12:08:14 2017 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Fri Sep 8 12:08:38 2017 -0400
----------------------------------------------------------------------
examples/go/example_test.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/7a5ded79/examples/go/example_test.go
----------------------------------------------------------------------
diff --git a/examples/go/example_test.go b/examples/go/example_test.go
index 6de309e..c36a775 100644
--- a/examples/go/example_test.go
+++ b/examples/go/example_test.go
@@ -153,7 +153,7 @@ func runExampleWant(t *testing.T, want string, prog string, args ...string) erro
func exampleArgs(args ...string) []string {
for i := 0; i < *connections; i++ {
- args = append(args, fmt.Sprintf("%s/%s%d", testBroker.addr, "q", i))
+ args = append(args, fmt.Sprintf("amqp://%s/%s%d", testBroker.addr, "q", i))
}
return args
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[2/2] qpid-proton git commit: PROTON-1579: go: restore testing with
-race
Posted by ac...@apache.org.
PROTON-1579: go: restore testing with -race
If there are still platform-specific problems, disable selectively for the
problem cases not in general.
Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/890a9d40
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/890a9d40
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/890a9d40
Branch: refs/heads/master
Commit: 890a9d407a1af8c096dcebb906126a9f27766079
Parents: f773c2c
Author: Alan Conway <ac...@redhat.com>
Authored: Fri Sep 8 12:00:50 2017 -0400
Committer: Alan Conway <ac...@redhat.com>
Committed: Fri Sep 8 12:08:38 2017 -0400
----------------------------------------------------------------------
proton-c/bindings/go/CMakeLists.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/890a9d40/proton-c/bindings/go/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/proton-c/bindings/go/CMakeLists.txt b/proton-c/bindings/go/CMakeLists.txt
index 7f814b9..ba7f754 100644
--- a/proton-c/bindings/go/CMakeLists.txt
+++ b/proton-c/bindings/go/CMakeLists.txt
@@ -22,14 +22,15 @@ execute_process(COMMAND ${GO_EXE} version OUTPUT_VARIABLE go_ver OUTPUT_STRIP_TR
message(STATUS "Found Go: ${GO_EXE} (${go_ver})")
set(GO_BUILD_FLAGS "" CACHE STRING "Flags for 'go build'")
-set(GO_TEST_FLAGS "-v" CACHE STRING "Flags for 'go test'")
set(GO_VET_FLAGS "-v" CACHE STRING "Flags for 'go test'")
# Flags that differ for golang go and gcc go.
if (go_ver MATCHES "gccgo")
- # TODO aconway 2015-10-08: import cycles with -race under gccgo, investigate.
+ # -race causes import cycles with gccgo.
+ set(GO_TEST_FLAGS "-v" CACHE STRING "Flags for 'go test'")
set(GO_RPATH_FLAGS -gccgoflags "-Wl,-rpath=${CMAKE_BINARY_DIR}/proton-c")
else()
+ set(GO_TEST_FLAGS "-v -race" CACHE STRING "Flags for 'go test'")
set(GO_RPATH_FLAGS -ldflags "-r ${CMAKE_BINARY_DIR}/proton-c")
endif()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org