You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Konrad Windszus (JIRA)" <ji...@apache.org> on 2016/05/12 11:33:12 UTC

[jira] [Commented] (SLING-5679) Move interface Customizer and customize() from junit.core to junit.teleporter

    [ https://issues.apache.org/jira/browse/SLING-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281433#comment-15281433 ] 

Konrad Windszus commented on SLING-5679:
----------------------------------------

The attached PR shows a backwards incompatible change. Given the fact that there are only few Customizers used in Sling itself (only 2) and that refactoring simplifies things a lot from the coding perspective (no longer casts necessary and much easier to understand when the customize is being called) I would consider moving that.
That would probably require a major version update on the JUnit Core bundle though. But since this code can be easily updated I would recommend to do that in this case.

Once we agree on doing that change, all Customizers need to be changed as well.
[~bdelacretaz] WDYT?

> Move interface Customizer and customize() from junit.core to junit.teleporter
> -----------------------------------------------------------------------------
>
>                 Key: SLING-5679
>                 URL: https://issues.apache.org/jira/browse/SLING-5679
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>    Affects Versions: JUnit Core 1.0.16, JUnit Tests Teleporter 1.0.6
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>
> As discussed in http://www.mail-archive.com/dev@sling.apache.org/msg55732.html the Customizer interface as well as the customize method makes only sense for the client-side of the teleporter rule. Therefore the interface and related methods should be moved from the junit.core to the junit.teleporter module.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)