You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/15 10:24:35 UTC
[GitHub] [rocketmq-externals] Git-Yang opened a new pull request #851: [ISSUE #844] Realize consumption offset synchronization
Git-Yang opened a new pull request #851:
URL: https://github.com/apache/rocketmq-externals/pull/851
## What is the purpose of the change
https://github.com/apache/rocketmq-externals/issues/844
## Brief changelog
- Add MetaSinkTask.
- Consistency check of consumption offset.
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou removed a comment on pull request #851: [ISSUE #844] Realize consumption offset synchronization
Posted by GitBox <gi...@apache.org>.
odbozhou removed a comment on pull request #851:
URL: https://github.com/apache/rocketmq-externals/pull/851#issuecomment-991575624
In my opinion, replicator is unique when it is used because its source and target are RocketMQ. In replicator's implementation, messages are consumed by consumers and sent by Runtime producer. Therefore, any RocketMQ cluster can be synchronized with the Replicator source connector, so the source should be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou commented on pull request #851: [ISSUE #844] Realize consumption offset synchronization
Posted by GitBox <gi...@apache.org>.
odbozhou commented on pull request #851:
URL: https://github.com/apache/rocketmq-externals/pull/851#issuecomment-991575624
In my opinion, replicator is unique when it is used because its source and target are RocketMQ. In replicator's implementation, messages are consumed by consumers and sent by Runtime producer. Therefore, any RocketMQ cluster can be synchronized with the Replicator source connector, so the source should be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou removed a comment on pull request #851: [ISSUE #844] Realize consumption offset synchronization
Posted by GitBox <gi...@apache.org>.
odbozhou removed a comment on pull request #851:
URL: https://github.com/apache/rocketmq-externals/pull/851#issuecomment-991575624
In my opinion, replicator is unique when it is used because its source and target are RocketMQ. In replicator's implementation, messages are consumed by consumers and sent by Runtime producer. Therefore, any RocketMQ cluster can be synchronized with the Replicator source connector, so the source should be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou commented on pull request #851: [ISSUE #844] Realize consumption offset synchronization
Posted by GitBox <gi...@apache.org>.
odbozhou commented on pull request #851:
URL: https://github.com/apache/rocketmq-externals/pull/851#issuecomment-991568535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] odbozhou commented on pull request #851: [ISSUE #844] Realize consumption offset synchronization
Posted by GitBox <gi...@apache.org>.
odbozhou commented on pull request #851:
URL: https://github.com/apache/rocketmq-externals/pull/851#issuecomment-991568535
In my opinion, replicator is unique when it is used because its source and target are RocketMQ. In replicator's implementation, messages are consumed by consumers and sent by Runtime producer. Therefore, any RocketMQ cluster can be synchronized with the Replicator source connector, so the source should be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] Git-Yang commented on pull request #851: [ISSUE #844] Realize consumption offset synchronization
Posted by GitBox <gi...@apache.org>.
Git-Yang commented on pull request #851:
URL: https://github.com/apache/rocketmq-externals/pull/851#issuecomment-968752369
OffsetMsgId needs to be added to the keys when synchronizing messages. The msg offset in source and target is verified by offsetMsyId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org