You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 18:55:56 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2912: WIP: Starting point for optimizer integration tests
andygrove opened a new pull request, #2912:
URL: https://github.com/apache/arrow-datafusion/pull/2912
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2911
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I would like integration tests in the optimizer crate where we can easily add SQL and expected output plans so we can catch regressions as new rules are added
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Single integration test as a template to follow
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2912: WIP: Starting point for optimizer integration tests
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2912:
URL: https://github.com/apache/arrow-datafusion/pull/2912#issuecomment-1224110425
I needed this style of integration test in https://github.com/apache/arrow-datafusion/pull/3229 so made the changes in that PR instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2912: WIP: Starting point for optimizer integration tests
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2912:
URL: https://github.com/apache/arrow-datafusion/pull/2912#issuecomment-1195941760
> @alamb that sounds great. Thank you.
I am a bit low on time for the moment -- I will try over the next few weeks (or maybe document / explain better the existing postgres integration test that @Jimexist worked on)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2912: WIP: Starting point for optimizer integration tests
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2912:
URL: https://github.com/apache/arrow-datafusion/pull/2912#issuecomment-1195210922
@alamb that sounds great. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2912: WIP: Starting point for optimizer integration tests
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2912:
URL: https://github.com/apache/arrow-datafusion/pull/2912#issuecomment-1184792882
@avantgardnerio This is a very rushed and hacky start, but do you think this could be the basis for useful tests?
I have benchmark SQL that I could add here to expose a number of existing optimizer bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2912: WIP: Starting point for optimizer integration tests
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2912:
URL: https://github.com/apache/arrow-datafusion/pull/2912#issuecomment-1185448490
> I would like integration tests in the optimizer crate where we can easily add SQL and expected output plans so we can catch regressions as new rules are added
This would be awesome -- note I have something similar in IOx that has the queries and expected plans in external files (which makes updating them much easier -- you can just copy the new output file and verify the diff).
if you would like I can try and port some of that to datafusion (perhaps after this PR is merged): https://github.com/influxdata/influxdb_iox/tree/main/query_tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed pull request #2912: WIP: Starting point for optimizer integration tests
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #2912: WIP: Starting point for optimizer integration tests
URL: https://github.com/apache/arrow-datafusion/pull/2912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org