[GitHub] [james-project] mbaechler commented on a diff in pull request #1463: Refactoring series focused on scala style

["mbaechler (via GitHub)" <gi...@apache.org>]

mbaechler commented on code in PR #1463:
URL: https://github.com/apache/james-project/pull/1463#discussion_r1116957436


##########
server/mailet/rate-limiter/src/main/scala/org/apache/james/transport/mailets/EntityType.scala:
##########
@@ -33,11 +33,15 @@ import scala.util.Try
 case class KeyPrefix(value: String)
 
 object ConfigurationOps {
+
+  implicit class OptionOps(mailetConfig: MailetConfig) {

Review Comment:
   Yes, segregation has a cost but I judged it to be acceptable for configuration parsing (which happens at start and is just about a few calls).
   Would you agree?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org