You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/16 01:56:26 UTC
[GitHub] [spark] sarutak opened a new pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
sarutak opened a new pull request #34915:
URL: https://github.com/apache/spark/pull/34915
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR upgrades SBT to `1.5.7`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
SBT 1.5.7 was released a few hours ago, which includes a fix for CVE-2021-45046.
Spark doesn't use Log4J 2.x for now, but it's to avoid potential vulnerability just in case.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
GA and AppVayor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995449712
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995476573
Oh yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995369735
Looks good if tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995417515
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50723/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995473829
BTW, can we have this at branch-3.2, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995477486
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995427127
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50723/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995449768
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146249/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995380170
**[Test build #146249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146249/testReport)** for PR 34915 at commit [`ccf2229`](https://github.com/apache/spark/commit/ccf2229305c8301b0a23e7b2a3f9bab8ef96eabd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995380170
**[Test build #146249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146249/testReport)** for PR 34915 at commit [`ccf2229`](https://github.com/apache/spark/commit/ccf2229305c8301b0a23e7b2a3f9bab8ef96eabd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995449712
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995427127
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50723/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995484526
@HyukjinKwon Thank you for cherry-picking for `branch-3.2` !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995400831
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50723/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995448234
**[Test build #146249 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146249/testReport)** for PR 34915 at commit [`ccf2229`](https://github.com/apache/spark/commit/ccf2229305c8301b0a23e7b2a3f9bab8ef96eabd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995477815
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995449768
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146249/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34915:
URL: https://github.com/apache/spark/pull/34915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34915: [SPARK-37656][BUILD] Upgrade SBT to 1.5.7
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34915:
URL: https://github.com/apache/spark/pull/34915#issuecomment-995472880
+1, LGTM. Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org