You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/02/23 07:22:30 UTC

[GitHub] [shardingsphere] jingshanglu opened a new issue #9471: Add UT for grantStatement and revokeStatement

jingshanglu opened a new issue #9471:
URL: https://github.com/apache/shardingsphere/issues/9471


   ## Background
   Now, `grant` and `revoke` in statement  are improved, so origin UT for it is not suitable. We need to add UT for `grant` and `revoke`.
   parser UT entry:`shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/SQLParserParameterizedTest.java->assertSupportedSQL()`
   
   
   ## Solutions
   1. Think about design of xxxAssert.java.
   2. change expected result.(path:`shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/case`)
   3. The test class runs successfully(`shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/SQLParserParameterizedTest.java).
   
   ### eg
   * #7880 
   
   ## Note
   We can discuss the reasonableness of the design and then implement it.
   
   ### subtasks
   
   - []  add UT for `grant`
   - []  add UT for `revoke`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] HoldDie commented on issue #9471: Add UT for grantStatement and revokeStatement

Posted by GitBox <gi...@apache.org>.
HoldDie commented on issue #9471:
URL: https://github.com/apache/shardingsphere/issues/9471#issuecomment-787796206


   1
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] HoldDie commented on issue #9471: Add UT for grantStatement and revokeStatement

Posted by GitBox <gi...@apache.org>.
HoldDie commented on issue #9471:
URL: https://github.com/apache/shardingsphere/issues/9471#issuecomment-787796631


   pls assign me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 commented on issue #9471: Add UT for grantStatement and revokeStatement

Posted by GitBox <gi...@apache.org>.
yu199195 commented on issue #9471:
URL: https://github.com/apache/shardingsphere/issues/9471#issuecomment-787812748


   @HoldDie  welcome.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org