You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jeremy Lingmann <3h...@snkmail.com> on 2014/01/17 19:47:48 UTC

Review Request 17057: Deploying Aurora documentation improvements

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17057/
-----------------------------------------------------------

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
-------

Deploying Aurora documentation improvements

* Update the path examples so they are correct (dist instead of build, handle versioned build file names)
* Fix a few markdown formatting issues
* Add additional info on the requirements to build a distribution zip file


Diffs
-----

  docs/deploying-aurora-scheduler.md c11f2a9fd91e6826e227e320aa94a0a529191a3e 

Diff: https://reviews.apache.org/r/17057/diff/


Testing
-------

Previewed markdown changes with grip: https://github.com/joeyespo/grip


Thanks,

Jeremy Lingmann


Re: Review Request 17057: Deploying Aurora documentation improvements

Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17057/#review32204
-----------------------------------------------------------

Ship it!


Ship It!

- Jake Farrell


On Jan. 17, 2014, 6:47 p.m., Jeremy Lingmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17057/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 6:47 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deploying Aurora documentation improvements
> 
> * Update the path examples so they are correct (dist instead of build, handle versioned build file names)
> * Fix a few markdown formatting issues
> * Add additional info on the requirements to build a distribution zip file
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md c11f2a9fd91e6826e227e320aa94a0a529191a3e 
> 
> Diff: https://reviews.apache.org/r/17057/diff/
> 
> 
> Testing
> -------
> 
> Previewed markdown changes with grip: https://github.com/joeyespo/grip
> 
> 
> Thanks,
> 
> Jeremy Lingmann
> 
>


Re: Review Request 17057: Deploying Aurora documentation improvements

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17057/#review32172
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Jan. 17, 2014, 10:47 a.m., Jeremy Lingmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17057/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 10:47 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deploying Aurora documentation improvements
> 
> * Update the path examples so they are correct (dist instead of build, handle versioned build file names)
> * Fix a few markdown formatting issues
> * Add additional info on the requirements to build a distribution zip file
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md c11f2a9fd91e6826e227e320aa94a0a529191a3e 
> 
> Diff: https://reviews.apache.org/r/17057/diff/
> 
> 
> Testing
> -------
> 
> Previewed markdown changes with grip: https://github.com/joeyespo/grip
> 
> 
> Thanks,
> 
> Jeremy Lingmann
> 
>


Re: Review Request 17057: Deploying Aurora documentation improvements

Posted by Jeremy Lingmann <3h...@snkmail.com>.

> On Jan. 17, 2014, 6:50 p.m., Jake Farrell wrote:
> > Is there a ticket for this?

Hi Jake, no ticket I was just trying to provide some feedback on the documentation. Let me know if you would like me to create a ticket or submit through other channels.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17057/#review32170
-----------------------------------------------------------


On Jan. 17, 2014, 6:47 p.m., Jeremy Lingmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17057/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 6:47 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deploying Aurora documentation improvements
> 
> * Update the path examples so they are correct (dist instead of build, handle versioned build file names)
> * Fix a few markdown formatting issues
> * Add additional info on the requirements to build a distribution zip file
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md c11f2a9fd91e6826e227e320aa94a0a529191a3e 
> 
> Diff: https://reviews.apache.org/r/17057/diff/
> 
> 
> Testing
> -------
> 
> Previewed markdown changes with grip: https://github.com/joeyespo/grip
> 
> 
> Thanks,
> 
> Jeremy Lingmann
> 
>


Re: Review Request 17057: Deploying Aurora documentation improvements

Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17057/#review32170
-----------------------------------------------------------


Is there a ticket for this?

- Jake Farrell


On Jan. 17, 2014, 6:47 p.m., Jeremy Lingmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17057/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 6:47 p.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deploying Aurora documentation improvements
> 
> * Update the path examples so they are correct (dist instead of build, handle versioned build file names)
> * Fix a few markdown formatting issues
> * Add additional info on the requirements to build a distribution zip file
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md c11f2a9fd91e6826e227e320aa94a0a529191a3e 
> 
> Diff: https://reviews.apache.org/r/17057/diff/
> 
> 
> Testing
> -------
> 
> Previewed markdown changes with grip: https://github.com/joeyespo/grip
> 
> 
> Thanks,
> 
> Jeremy Lingmann
> 
>


Re: Review Request 17057: Deploying Aurora documentation improvements

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17057/#review32205
-----------------------------------------------------------


Thanks for the contribution, I've merged this to master. Please mark this review submitted at your convenience.

- Kevin Sweeney


On Jan. 17, 2014, 10:47 a.m., Jeremy Lingmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17057/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 10:47 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deploying Aurora documentation improvements
> 
> * Update the path examples so they are correct (dist instead of build, handle versioned build file names)
> * Fix a few markdown formatting issues
> * Add additional info on the requirements to build a distribution zip file
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md c11f2a9fd91e6826e227e320aa94a0a529191a3e 
> 
> Diff: https://reviews.apache.org/r/17057/diff/
> 
> 
> Testing
> -------
> 
> Previewed markdown changes with grip: https://github.com/joeyespo/grip
> 
> 
> Thanks,
> 
> Jeremy Lingmann
> 
>