You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/21 21:47:36 UTC
[GitHub] [beam] fernando-wizeline opened a new pull request, #23323: GA Migration PostCommit Beam Metrics Publish
fernando-wizeline opened a new pull request, #23323:
URL: https://github.com/apache/beam/pull/23323
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
Migrated workflow [job-postcommit-beam-metrics-publish.yml](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-beam-metrics-publish/.github/workflows/job-postcommit-beam-metrics-publish.yml)
The migrated workflow was removed from [.test-infra/jenkins/README.md](https://github.com/fernando-wizeline/beam/tree/gam-postcommit-beam-metrics-publish/.test-infra/jenkins/README.md) and added to [CI.md](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-beam-metrics-publish/CI.md)
DO NOT MERGE until the effort to use self-hosted runners is completed https://github.com/apache/beam/pull/22703
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23323: GA Migration PostCommit Beam Metrics Publish
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23323:
URL: https://github.com/apache/beam/pull/23323#issuecomment-1335178796
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23323: GA Migration PostCommit Beam Metrics Publish
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23323:
URL: https://github.com/apache/beam/pull/23323#issuecomment-1255254130
Tests were successful on the latest runner (2.296.2). Nonetheless, I’d recommend holding off on the migration of this particular workflow since the version of the runner needed (2.296.2) breaks functionality for other workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23323: GA Migration PostCommit Beam Metrics Publish
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23323:
URL: https://github.com/apache/beam/pull/23323#discussion_r983903568
##########
.test-infra/metrics/build.gradle:
##########
@@ -123,9 +123,9 @@ task deploy {
exec {
executable 'sh'
args '-c', "kubectl set image deployment/beamgrafana \
- beamgrafana=gcr.io/apache-beam-testing/beamgrafana:${project.lastCommitId} \
- beammetricssyncjenkins=gcr.io/apache-beam-testing/beammetricssyncjenkins:${project.lastCommitId} \
- beammetricssyncgithub=gcr.io/apache-beam-testing/beammetricssyncgithub:${project.lastCommitId}"
+ beamgrafana-test=gcr.io/apache-beam-testing/beamgrafana-test:${project.lastCommitId} \
Review Comment:
Oh I need to change this one to the correct values.
For testing purposes we targeted it to another instance.
Thanks for the heads up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23323: GA Migration PostCommit Beam Metrics Publish
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23323:
URL: https://github.com/apache/beam/pull/23323#discussion_r983848553
##########
.test-infra/metrics/build.gradle:
##########
@@ -123,9 +123,9 @@ task deploy {
exec {
executable 'sh'
args '-c', "kubectl set image deployment/beamgrafana \
- beamgrafana=gcr.io/apache-beam-testing/beamgrafana:${project.lastCommitId} \
- beammetricssyncjenkins=gcr.io/apache-beam-testing/beammetricssyncjenkins:${project.lastCommitId} \
- beammetricssyncgithub=gcr.io/apache-beam-testing/beammetricssyncgithub:${project.lastCommitId}"
+ beamgrafana-test=gcr.io/apache-beam-testing/beamgrafana-test:${project.lastCommitId} \
Review Comment:
Why are we retargeting these?
##########
.github/workflows/job-postcommit-beam-metrics-publish.yml:
##########
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Applies new configuration to Beam Metrics infrastructure.
+
+name: PostCommit Beam Metrics Publish
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master']
+permissions: read-all
+
+jobs:
+ postcommit-beam-metrics-publish:
+ name: Run PostCommit Beam Metrics Publish
+ runs-on: [self-hosted, ubuntu-20.04]
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: recursive
Review Comment:
Do we really need to check out the submodules here? I imagine for most of these workflows we don't. The only places we should need them are when we're using one of the actions listed here (https://github.com/apache/beam/blob/master/.gitmodules) which I don't think we do in any of the migrated workflows, or when updating the website (where it may or may not be necessary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23323: GA Migration PostCommit Beam Metrics Publish
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23323:
URL: https://github.com/apache/beam/pull/23323#issuecomment-1345257373
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #23323: GA Migration PostCommit Beam Metrics Publish
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #23323: GA Migration PostCommit Beam Metrics Publish
URL: https://github.com/apache/beam/pull/23323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org