You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2016/08/03 22:51:05 UTC
[1/2] mesos git commit: Updated 'NvidiaVolume' to not error out when
binary is missing.
Repository: mesos
Updated Branches:
refs/heads/1.0.x d3e6a857e -> c2e6cc649
Updated 'NvidiaVolume' to not error out when binary is missing.
Previously, when building the volume, we would error out if a binary
we were trying to add was not found on the host filesystem. However,
these are not the semantics that we want. By design, we list all the
binaries the *may* exist on the filesystem that we want to put in the
volume, not all of the binaries that *must* exist. To this end, we
should simply skip any unfound binaries and move on to the next one
instead of erroring out.
Review: https://reviews.apache.org/r/50762/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e9a97c39
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e9a97c39
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e9a97c39
Branch: refs/heads/1.0.x
Commit: e9a97c393aaccdd479e804105b533290a08f0a65
Parents: d3e6a85
Author: Kevin Klues <kl...@gmail.com>
Authored: Wed Aug 3 15:05:15 2016 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Wed Aug 3 15:48:27 2016 -0700
----------------------------------------------------------------------
.../mesos/isolators/gpu/volume.cpp | 29 ++++++++++----------
1 file changed, 14 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/e9a97c39/src/slave/containerizer/mesos/isolators/gpu/volume.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/isolators/gpu/volume.cpp b/src/slave/containerizer/mesos/isolators/gpu/volume.cpp
index 478e106..478752f 100644
--- a/src/slave/containerizer/mesos/isolators/gpu/volume.cpp
+++ b/src/slave/containerizer/mesos/isolators/gpu/volume.cpp
@@ -283,24 +283,23 @@ Try<NvidiaVolume> NvidiaVolume::create()
if (!os::exists(path)) {
string command = "which " + binary;
Try<string> which = os::shell(command);
- if (which.isError()) {
- return Error("Failed to os::shell '" + command + "': " + which.error());
- }
- which = strings::trim(which.get());
+ if (which.isSome()) {
+ which = strings::trim(which.get());
- Result<string> realpath = os::realpath(which.get());
- if (!realpath.isSome()) {
- return Error("Failed to os::realpath '" + which.get() + "':"
- " " + (realpath.isError()
- ? realpath.error()
- : "No such file or directory"));
- }
+ Result<string> realpath = os::realpath(which.get());
+ if (!realpath.isSome()) {
+ return Error("Failed to os::realpath '" + which.get() + "':"
+ " " + (realpath.isError()
+ ? realpath.error()
+ : "No such file or directory"));
+ }
- command = "cp " + realpath.get() + " " + path;
- Try<string> cp = os::shell(command);
- if (cp.isError()) {
- return Error("Failed to os::shell '" + command + "': " + cp.error());
+ command = "cp " + realpath.get() + " " + path;
+ Try<string> cp = os::shell(command);
+ if (cp.isError()) {
+ return Error("Failed to os::shell '" + command + "': " + cp.error());
+ }
}
}
}
[2/2] mesos git commit: Added MESOS-5982 to the 1.0.1 CHANGELOG.
Posted by bm...@apache.org.
Added MESOS-5982 to the 1.0.1 CHANGELOG.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/c2e6cc64
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/c2e6cc64
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/c2e6cc64
Branch: refs/heads/1.0.x
Commit: c2e6cc649ed9144084d0cd69d781bada8ef425be
Parents: e9a97c3
Author: Benjamin Mahler <bm...@apache.org>
Authored: Wed Aug 3 15:50:45 2016 -0700
Committer: Benjamin Mahler <bm...@apache.org>
Committed: Wed Aug 3 15:50:45 2016 -0700
----------------------------------------------------------------------
CHANGELOG | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/c2e6cc64/CHANGELOG
----------------------------------------------------------------------
diff --git a/CHANGELOG b/CHANGELOG
index 389ece7..f3112db 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -12,6 +12,7 @@ All Issues:
* [MESOS-5943] - Incremental http parsing of URLs leads to decoder error.
* [MESOS-5945] - NvidiaVolume::create() should check for root before creating volume.
* [MESOS-5959] - All non-root tests fail on GPU machine.
+ * [MESOS-5982] - NvidiaVolume errors out if any Nvidia binary is missing.
Release Notes - Mesos - Version 1.0.0