You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/02 00:34:00 UTC
[jira] [Work logged] (HDFS-16595) Slow peer metrics - add median, mad and upper latency limits
[ https://issues.apache.org/jira/browse/HDFS-16595?focusedWorklogId=777224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777224 ]
ASF GitHub Bot logged work on HDFS-16595:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 00:33
Start Date: 02/Jun/22 00:33
Worklog Time Spent: 10m
Work Description: jojochuang commented on code in PR #4357:
URL: https://github.com/apache/hadoop/pull/4357#discussion_r887401881
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java:
##########
@@ -853,11 +854,14 @@ public static List<SlowPeerReportProto> convertSlowPeerInfo(
List<SlowPeerReportProto> slowPeerInfoProtos =
new ArrayList<>(slowPeers.getSlowPeers().size());
- for (Map.Entry<String, Double> entry :
- slowPeers.getSlowPeers().entrySet()) {
- slowPeerInfoProtos.add(SlowPeerReportProto.newBuilder()
+ for (Map.Entry<String, OutlierMetrics> entry : slowPeers.getSlowPeers().entrySet()) {
+ OutlierMetrics outlierMetrics = entry.getValue();
+ slowPeerInfoProtos.add(
+ SlowPeerReportProto.newBuilder()
.setDataNodeId(entry.getKey())
- .setAggregateLatency(entry.getValue())
+ .setAggregateLatency(outlierMetrics.getActualLatency())
+ .setMedian(outlierMetrics.getMedian()).setMad(outlierMetrics.getMad())
Review Comment:
move .setMad to its own line?
```suggestion
.setMedian(outlierMetrics.getMedian())
.setMad(outlierMetrics.getMad())
```
Issue Time Tracking
-------------------
Worklog Id: (was: 777224)
Time Spent: 2h 20m (was: 2h 10m)
> Slow peer metrics - add median, mad and upper latency limits
> ------------------------------------------------------------
>
> Key: HDFS-16595
> URL: https://issues.apache.org/jira/browse/HDFS-16595
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Slow datanode metrics include slow node and it's reporting node details. With HDFS-16582, we added the aggregate latency that is perceived by the reporting nodes.
> In order to get more insights into how the outlier slownode's latencies differ from the rest of the nodes, we should also expose median, median absolute deviation and the calculated upper latency limit details.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org