You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/14 09:31:50 UTC
[GitHub] [shardingsphere] tswstarplanet opened a new pull request #6030: fix issue_6029, add listener to cache before start cache, and avoid a…
tswstarplanet opened a new pull request #6030:
URL: https://github.com/apache/shardingsphere/pull/6030
…dd listener of same path to cache multiple times
Fixes #6029.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tswstarplanet removed a comment on pull request #6030: fix issue_6029, add listener to cache before start cache, and avoid a…
Posted by GitBox <gi...@apache.org>.
tswstarplanet removed a comment on pull request #6030:
URL: https://github.com/apache/shardingsphere/pull/6030#issuecomment-643750045
Maybe we should use sync ? If one path has multiple listeners, Is there chances to cause multiple consumes of an data change event ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6030: fix issue_6029, add listener to cache before start cache, and avoid a…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6030:
URL: https://github.com/apache/shardingsphere/pull/6030#issuecomment-643744124
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6030?src=pr&el=h1) Report
> Merging [#6030](https://codecov.io/gh/apache/shardingsphere/pull/6030?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8c79331f53a6f380450e91bc91acf01bd0fe5b08&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `61.53%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6030?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6030 +/- ##
============================================
- Coverage 53.11% 53.10% -0.01%
+ Complexity 438 437 -1
============================================
Files 1194 1194
Lines 20941 20938 -3
Branches 3767 3767
============================================
- Hits 11122 11119 -3
Misses 9122 9122
Partials 697 697
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/6030?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ter/instance/CuratorZookeeperCenterRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/6030/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtY29udHJvbC1wYW5lbC9zaGFyZGluZ3NwaGVyZS1vcmNoZXN0cmF0aW9uL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyL3NoYXJkaW5nc3BoZXJlLW9yY2hlc3RyYXRpb24tY2VudGVyLXpvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NlbnRlci9pbnN0YW5jZS9DdXJhdG9yWm9va2VlcGVyQ2VudGVyUmVwb3NpdG9yeS5qYXZh) | `73.91% <61.53%> (-0.67%)` | `25.00 <2.00> (-1.00)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6030?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6030?src=pr&el=footer). Last update [8c79331...4491899](https://codecov.io/gh/apache/shardingsphere/pull/6030?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking closed pull request #6030: fix issue_6029, add listener to cache before start cache, and avoid a…
Posted by GitBox <gi...@apache.org>.
kimmking closed pull request #6030:
URL: https://github.com/apache/shardingsphere/pull/6030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tswstarplanet commented on pull request #6030: fix issue_6029, add listener to cache before start cache, and avoid a…
Posted by GitBox <gi...@apache.org>.
tswstarplanet commented on pull request #6030:
URL: https://github.com/apache/shardingsphere/pull/6030#issuecomment-643750045
Maybe we should use sync ? If one path has multiple listeners, Is there chances to cause multiple consumes of an data change event ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org