You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/03/31 08:51:41 UTC
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17246
Change subject: Only fetch needed branches in compare_branches.py
......................................................................
Only fetch needed branches in compare_branches.py
Fetching all branches of a remote repo will be time-consuming. This
changes compare_branches.py to only fetch the needed branches, i.e.
source_branch and target_branch.
Tests:
- Before this change, it can't finish in 30 mins when comparing two
downstream branches. After this change, it finishes in one minute.
Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
---
M bin/compare_branches.py
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/17246/1
--
To view, visit http://gerrit.cloudera.org:8080/17246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Gerrit-Change-Number: 17246
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17246 )
Change subject: Only fetch needed branches in compare_branches.py
......................................................................
Only fetch needed branches in compare_branches.py
Fetching all branches of a remote repo will be time-consuming. This
changes compare_branches.py to only fetch the needed branches, i.e.
source_branch and target_branch.
Tests:
- Before this change, it can't finish in 30 mins when comparing two
downstream branches. After this change, it finishes in one minute.
Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Reviewed-on: http://gerrit.cloudera.org:8080/17246
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/compare_branches.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Gerrit-Change-Number: 17246
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 )
Change subject: Only fetch needed branches in compare_branches.py
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/8473/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/17246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Gerrit-Change-Number: 17246
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 09:01:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 )
Change subject: Only fetch needed branches in compare_branches.py
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Gerrit-Change-Number: 17246
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 04:32:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 )
Change subject: Only fetch needed branches in compare_branches.py
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Gerrit-Change-Number: 17246
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:20:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 )
Change subject: Only fetch needed branches in compare_branches.py
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7036/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Gerrit-Change-Number: 17246
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 22:20:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Only fetch needed branches in compare branches.py
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17246 )
Change subject: Only fetch needed branches in compare_branches.py
......................................................................
Patch Set 1: Code-Review+2
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/17246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c70ad4de1fa79498ca32853b6ea99aee2d40a7
Gerrit-Change-Number: 17246
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 20:52:41 +0000
Gerrit-HasComments: No