You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Gergo Barna <bp...@gmail.com> on 2017/09/26 11:32:23 UTC
Review Request 62566: [ATLAS-2172] Atlas AD search filter is not get
honored when logging into Atlas UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62566/
-----------------------------------------------------------
Review request for atlas.
Repository: atlas
Description
-------
there was a missing setSearchFilter API call which is only present in the Spring Security API from version 3.2.6
https://docs.spring.io/spring-security/site/docs/3.2.6.RELEASE/apidocs/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.html
Diffs
-----
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java b123c52d065abea5c21f8a430c7ef8f830bc04a6
webapp/src/main/webapp/WEB-INF/applicationContext.xml aae2aa0116000d030070192249c930af35e84f0e
Diff: https://reviews.apache.org/r/62566/diff/1/
Testing
-------
File Attachments
----------------
ATLAS-2172.rbt.diff
https://reviews.apache.org/media/uploaded/files/2017/09/26/b94020c8-e019-452d-99b2-104115a19546__ATLAS-2172.rbt.diff
Thanks,
Gergo Barna
Re: Review Request 62566: [ATLAS-2172] Atlas AD search filter is not
get honored when logging into Atlas UI
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62566/#review186241
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On Sept. 26, 2017, 11:57 a.m., Gergo Barna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62566/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 11:57 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> there was a missing setSearchFilter API call which is only present in the Spring Security API from version 3.2.6
> https://docs.spring.io/spring-security/site/docs/3.2.6.RELEASE/apidocs/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.html
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java b123c52d065abea5c21f8a430c7ef8f830bc04a6
> webapp/src/main/webapp/WEB-INF/applicationContext.xml aae2aa0116000d030070192249c930af35e84f0e
>
>
> Diff: https://reviews.apache.org/r/62566/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ATLAS-2172.rbt.diff
> https://reviews.apache.org/media/uploaded/files/2017/09/26/b94020c8-e019-452d-99b2-104115a19546__ATLAS-2172.rbt.diff
>
>
> Thanks,
>
> Gergo Barna
>
>
Re: Review Request 62566: [ATLAS-2172] Atlas AD search filter is not
get honored when logging into Atlas UI
Posted by Gergo Barna <bp...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62566/
-----------------------------------------------------------
(Updated szept. 26, 2017, 11:57 de)
Review request for atlas and Madhan Neethiraj.
Repository: atlas
Description
-------
there was a missing setSearchFilter API call which is only present in the Spring Security API from version 3.2.6
https://docs.spring.io/spring-security/site/docs/3.2.6.RELEASE/apidocs/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.html
Diffs (updated)
-----
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java b123c52d065abea5c21f8a430c7ef8f830bc04a6
webapp/src/main/webapp/WEB-INF/applicationContext.xml aae2aa0116000d030070192249c930af35e84f0e
Diff: https://reviews.apache.org/r/62566/diff/2/
Changes: https://reviews.apache.org/r/62566/diff/1-2/
Testing
-------
File Attachments
----------------
ATLAS-2172.rbt.diff
https://reviews.apache.org/media/uploaded/files/2017/09/26/b94020c8-e019-452d-99b2-104115a19546__ATLAS-2172.rbt.diff
Thanks,
Gergo Barna
Re: Review Request 62566: [ATLAS-2172] Atlas AD search filter is not
get honored when logging into Atlas UI
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62566/#review186232
-----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java
Lines 143 (patched)
<https://reviews.apache.org/r/62566/#comment262715>
if adUserSearchFilter is null or isblank, set default string "(sAMAccountName={0})", check line number number 97.
- Nixon Rodrigues
On Sept. 26, 2017, 11:32 a.m., Gergo Barna wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62566/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 11:32 a.m.)
>
>
> Review request for atlas.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> there was a missing setSearchFilter API call which is only present in the Spring Security API from version 3.2.6
> https://docs.spring.io/spring-security/site/docs/3.2.6.RELEASE/apidocs/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.html
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java b123c52d065abea5c21f8a430c7ef8f830bc04a6
> webapp/src/main/webapp/WEB-INF/applicationContext.xml aae2aa0116000d030070192249c930af35e84f0e
>
>
> Diff: https://reviews.apache.org/r/62566/diff/1/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> ATLAS-2172.rbt.diff
> https://reviews.apache.org/media/uploaded/files/2017/09/26/b94020c8-e019-452d-99b2-104115a19546__ATLAS-2172.rbt.diff
>
>
> Thanks,
>
> Gergo Barna
>
>