You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Newton Alex <na...@pivotal.io> on 2016/02/22 19:58:10 UTC
Review Request 43845: Unit tests doesn't export scripts from
common-services folder into PYTHONPATH
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43845/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-14821
https://issues.apache.org/jira/browse/AMBARI-14821
Repository: ambari
Description
-------
Unit tests doesn't export scripts from common-services folder into PYTHONPATH
Diffs
-----
ambari-server/src/test/python/unitTests.py 6368ca1
Diff: https://reviews.apache.org/r/43845/diff/
Testing
-------
The unit tests passed
```
test_validationMinMax (test_stack_advisor.TestHDP206StackAdvisor) ... ok
test_validationNamenodeAndSecondaryNamenode2Hosts_noMessagesForSameHost (test_stack_advisor.TestHDP206StackAdvisor) ... ok
test_validationWarnMessagesIfLessThanDefault (test_stack_advisor.TestHDP206StackAdvisor) ... ok
test_validatorEnoughDiskSpace (test_stack_advisor.TestHDP206StackAdvisor) ... ok
----------------------------------------------------------------------
Ran 37 tests in 0.077s
...
OK
Running tests for stack:2.0.6 service:before-INSTALL
test_hook_default (test_before_install.TestHookBeforeInstall) ... ok
----------------------------------------------------------------------
Ran 1 test in 0.023s
OK
Running tests for stack:2.0.6 service:before-START
test_hook_default (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,842 - Using hadoop conf dir: /etc/hadoop/conf
ok
test_hook_default_hdfs (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,907 - Using hadoop conf dir: /etc/hadoop/conf
ok
test_hook_refresh_topology_custom_directories (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,969 - Using hadoop conf dir: /etc/hadoop/conf
ok
test_hook_secured (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:11,028 - Using hadoop conf dir: /etc/hadoop/conf
ok
----------------------------------------------------------------------
Ran 4 tests in 0.254s
OK...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [7.680s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.244s]
[INFO] Ambari Web ........................................ SUCCESS [1:41.096s]
[INFO] Ambari Views ...................................... SUCCESS [10.076s]
[INFO] Ambari Admin View ................................. SUCCESS [15.339s]
[INFO] ambari-metrics .................................... SUCCESS [0.737s]
[INFO] Ambari Metrics Common ............................. SUCCESS [3.933s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [6.933s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [4.318s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [5.493s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.808s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [6:51.190s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [3.405s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [47.021s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [7:08.869s]
[INFO] Ambari Server ..................................... SUCCESS [1:15:01.678s]
[INFO] Ambari Functional Tests ........................... SUCCESS [3.113s]
[INFO] Ambari Agent ...................................... SUCCESS [1:16.953s]
[INFO] Ambari Client ..................................... SUCCESS [0.212s]
[INFO] Ambari Python Client .............................. SUCCESS [3.408s]
[INFO] Ambari Groovy Client .............................. SUCCESS [13.774s]
[INFO] Ambari Shell ...................................... SUCCESS [0.223s]
[INFO] Ambari Python Shell ............................... SUCCESS [1.037s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.407s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:34:21.847s
[INFO] Finished at: Fri Feb 19 23:16:29 UTC 2016
[INFO] Final Memory: 301M/1243M
[INFO] ------------------------------------------------------------------------
```
Thanks,
Newton Alex
Re: Review Request 43845: Unit tests doesn't export scripts from
common-services folder into PYTHONPATH
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43845/#review120180
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On Feb. 22, 2016, 10:58 a.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43845/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 10:58 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-14821
> https://issues.apache.org/jira/browse/AMBARI-14821
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Unit tests doesn't export scripts from common-services folder into PYTHONPATH
>
>
> Diffs
> -----
>
> ambari-server/src/test/python/unitTests.py 6368ca1
>
> Diff: https://reviews.apache.org/r/43845/diff/
>
>
> Testing
> -------
>
> The unit tests passed
> ```
> test_validationMinMax (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationNamenodeAndSecondaryNamenode2Hosts_noMessagesForSameHost (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationWarnMessagesIfLessThanDefault (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validatorEnoughDiskSpace (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> ----------------------------------------------------------------------
> Ran 37 tests in 0.077s
> ...
> OK
> Running tests for stack:2.0.6 service:before-INSTALL
> test_hook_default (test_before_install.TestHookBeforeInstall) ... ok
> ----------------------------------------------------------------------
> Ran 1 test in 0.023s
> OK
> Running tests for stack:2.0.6 service:before-START
> test_hook_default (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,842 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_default_hdfs (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,907 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_refresh_topology_custom_directories (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,969 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_secured (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:11,028 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> ----------------------------------------------------------------------
> Ran 4 tests in 0.254s
> OK...
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [7.680s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.244s]
> [INFO] Ambari Web ........................................ SUCCESS [1:41.096s]
> [INFO] Ambari Views ...................................... SUCCESS [10.076s]
> [INFO] Ambari Admin View ................................. SUCCESS [15.339s]
> [INFO] ambari-metrics .................................... SUCCESS [0.737s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [3.933s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [6.933s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [4.318s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [5.493s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.808s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [6:51.190s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [3.405s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [47.021s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [7:08.869s]
> [INFO] Ambari Server ..................................... SUCCESS [1:15:01.678s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [3.113s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:16.953s]
> [INFO] Ambari Client ..................................... SUCCESS [0.212s]
> [INFO] Ambari Python Client .............................. SUCCESS [3.408s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [13.774s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.223s]
> [INFO] Ambari Python Shell ............................... SUCCESS [1.037s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.407s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:34:21.847s
> [INFO] Finished at: Fri Feb 19 23:16:29 UTC 2016
> [INFO] Final Memory: 301M/1243M
> [INFO] ------------------------------------------------------------------------
> ```
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 43845: Unit tests doesn't export scripts from
common-services folder into PYTHONPATH
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43845/#review120187
-----------------------------------------------------------
Ship it!
Ship It!
- jun aoki
On Feb. 22, 2016, 6:58 p.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43845/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-14821
> https://issues.apache.org/jira/browse/AMBARI-14821
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Unit tests doesn't export scripts from common-services folder into PYTHONPATH
>
>
> Diffs
> -----
>
> ambari-server/src/test/python/unitTests.py 6368ca1
>
> Diff: https://reviews.apache.org/r/43845/diff/
>
>
> Testing
> -------
>
> The unit tests passed
> ```
> test_validationMinMax (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationNamenodeAndSecondaryNamenode2Hosts_noMessagesForSameHost (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationWarnMessagesIfLessThanDefault (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validatorEnoughDiskSpace (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> ----------------------------------------------------------------------
> Ran 37 tests in 0.077s
> ...
> OK
> Running tests for stack:2.0.6 service:before-INSTALL
> test_hook_default (test_before_install.TestHookBeforeInstall) ... ok
> ----------------------------------------------------------------------
> Ran 1 test in 0.023s
> OK
> Running tests for stack:2.0.6 service:before-START
> test_hook_default (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,842 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_default_hdfs (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,907 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_refresh_topology_custom_directories (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,969 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_secured (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:11,028 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> ----------------------------------------------------------------------
> Ran 4 tests in 0.254s
> OK...
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [7.680s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.244s]
> [INFO] Ambari Web ........................................ SUCCESS [1:41.096s]
> [INFO] Ambari Views ...................................... SUCCESS [10.076s]
> [INFO] Ambari Admin View ................................. SUCCESS [15.339s]
> [INFO] ambari-metrics .................................... SUCCESS [0.737s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [3.933s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [6.933s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [4.318s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [5.493s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.808s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [6:51.190s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [3.405s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [47.021s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [7:08.869s]
> [INFO] Ambari Server ..................................... SUCCESS [1:15:01.678s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [3.113s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:16.953s]
> [INFO] Ambari Client ..................................... SUCCESS [0.212s]
> [INFO] Ambari Python Client .............................. SUCCESS [3.408s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [13.774s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.223s]
> [INFO] Ambari Python Shell ............................... SUCCESS [1.037s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.407s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:34:21.847s
> [INFO] Finished at: Fri Feb 19 23:16:29 UTC 2016
> [INFO] Final Memory: 301M/1243M
> [INFO] ------------------------------------------------------------------------
> ```
>
>
> Thanks,
>
> Newton Alex
>
>
Re: Review Request 43845: Unit tests doesn't export scripts from
common-services folder into PYTHONPATH
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43845/#review120186
-----------------------------------------------------------
ambari-server/src/test/python/unitTests.py (line 116)
<https://reviews.apache.org/r/43845/#comment181615>
import glob
for scripts_dir in glob.glob(os.path.join(base_commserv_folder, service, "*", "package", "scripts")):
script_folders.add(scripts_dir)
- Lav Jain
On Feb. 22, 2016, 6:58 p.m., Newton Alex wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43845/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 6:58 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-14821
> https://issues.apache.org/jira/browse/AMBARI-14821
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Unit tests doesn't export scripts from common-services folder into PYTHONPATH
>
>
> Diffs
> -----
>
> ambari-server/src/test/python/unitTests.py 6368ca1
>
> Diff: https://reviews.apache.org/r/43845/diff/
>
>
> Testing
> -------
>
> The unit tests passed
> ```
> test_validationMinMax (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationNamenodeAndSecondaryNamenode2Hosts_noMessagesForSameHost (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validationWarnMessagesIfLessThanDefault (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> test_validatorEnoughDiskSpace (test_stack_advisor.TestHDP206StackAdvisor) ... ok
> ----------------------------------------------------------------------
> Ran 37 tests in 0.077s
> ...
> OK
> Running tests for stack:2.0.6 service:before-INSTALL
> test_hook_default (test_before_install.TestHookBeforeInstall) ... ok
> ----------------------------------------------------------------------
> Ran 1 test in 0.023s
> OK
> Running tests for stack:2.0.6 service:before-START
> test_hook_default (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,842 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_default_hdfs (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,907 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_refresh_topology_custom_directories (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:10,969 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> test_hook_secured (test_before_start.TestHookBeforeStart) ... 2016-02-19 23:10:11,028 - Using hadoop conf dir: /etc/hadoop/conf
> ok
> ----------------------------------------------------------------------
> Ran 4 tests in 0.254s
> OK...
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [7.680s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.244s]
> [INFO] Ambari Web ........................................ SUCCESS [1:41.096s]
> [INFO] Ambari Views ...................................... SUCCESS [10.076s]
> [INFO] Ambari Admin View ................................. SUCCESS [15.339s]
> [INFO] ambari-metrics .................................... SUCCESS [0.737s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [3.933s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [6.933s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [4.318s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [5.493s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [3.808s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [6:51.190s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [3.405s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [47.021s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [7:08.869s]
> [INFO] Ambari Server ..................................... SUCCESS [1:15:01.678s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [3.113s]
> [INFO] Ambari Agent ...................................... SUCCESS [1:16.953s]
> [INFO] Ambari Client ..................................... SUCCESS [0.212s]
> [INFO] Ambari Python Client .............................. SUCCESS [3.408s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [13.774s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.223s]
> [INFO] Ambari Python Shell ............................... SUCCESS [1.037s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.407s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:34:21.847s
> [INFO] Finished at: Fri Feb 19 23:16:29 UTC 2016
> [INFO] Final Memory: 301M/1243M
> [INFO] ------------------------------------------------------------------------
> ```
>
>
> Thanks,
>
> Newton Alex
>
>