[jira] [Commented] (BEAM-438) Rename one of PTransform.apply and PInput.apply

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729977#comment-15729977 ] 

ASF GitHub Bot commented on BEAM-438:
-------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1538

    [BEAM-438] Rename PTransform.apply to PTransform.expand

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Opening this to have a code pointer in dev list discussion.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam PTransform-expand

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1538
    
----
commit ff50e4d470d954c17d73358aa3e0c4c8b4123b87
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-12-07T21:33:04Z

    Rename PTransform.apply to PTransform.expand

----


> Rename one of PTransform.apply and PInput.apply
> -----------------------------------------------
>
>                 Key: BEAM-438
>                 URL: https://issues.apache.org/jira/browse/BEAM-438
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Daniel Halperin
>              Labels: backward-incompatible
>
> Before releasing Beam 1.0, we should do this.
> Right now, it's legal to call:
> {{ptransform.apply(input)}}
> and 
> {{input.apply(ptransform)}}
> when only the latter is correct. The former skips various validation steps and loses the notion of composite transforms.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)