[jira] [Commented] (CASSANDRA-9986) Remove SliceableUnfilteredRowIterator

["Sylvain Lebresne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101851#comment-15101851 ] 

Sylvain Lebresne commented on CASSANDRA-9986:
---------------------------------------------

I apologize for dropping the ball on the review on this. If you can rebase against trunk, I'll make sure to review quickly.

> Remove SliceableUnfilteredRowIterator
> -------------------------------------
>
>                 Key: CASSANDRA-9986
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9986
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 3.x
>
>
> After CASSANDRA-9932, there is only one instance where this class is needed, and that is {{SSTableIterator}}. It would be much simpler if, like in {{AbstractBTreePartition}}, the slices were passed into the {{SSTableIterator}} on construction. This would make the control flow easier to follow both: 
> * logically, because:
> **  memtables and sstables would have the same access pattern; and
> ** our SSTableIterator would not have two modes of (parallel) operation, which is kind of confusing (the slices are independent of the non-sliced iteration)
> * in the debugger, because we would have one fewer wrapping iterator



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)