You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/06/06 13:00:39 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #35940: GH-35932: [Java] Make JDBC test less brittle
lidavidm opened a new pull request, #35940:
URL: https://github.com/apache/arrow/pull/35940
### Rationale for this change
A JDBC test is brittle because it compares string representations.
### What changes are included in this PR?
Compare values directly.
### Are these changes tested?
N/A
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578756498
Well. We can't upgrade Mockito to fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd merged pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #35940:
URL: https://github.com/apache/arrow/pull/35940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578749833
Weird, guess we somehow picked up java 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578827709
Revision: d4d1dadbd78a4215db4c6f55fb3c170f3ad6bdd6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8ea0a6250d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8ea0a6250d)
|Task|Status|
|----|------|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189488474/jobs/9354576667)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189488222/jobs/9354576535)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189488777/jobs/9354577522)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189489129/jobs/9354578324)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189489401/jobs/9354579077)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1580982334
Benchmark runs are scheduled for baseline = 745fa94f68f200d2a703b864d4b29ec8ee98a64d and contender = e7a9b29b50c27e7239bfdcaff683b41069c36910. e7a9b29b50c27e7239bfdcaff683b41069c36910 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0bdc4b31480843b29a05cf0b564c6f34...6d6dc8bfec1d4258b3e7de07a5bda16f/)
[Finished :arrow_down:0.38% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/838efe2ef7394be7b2a3b6ae64f20fb6...1a10bfbbddc84ed78c87c4e20e183c24/)
[Finished :arrow_down:0.65% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e3b862702c1b474182e8b8d4d32fbfd3...22470ee9257f49ee8f37e2b6958fc282/)
[Failed :arrow_down:0.18% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/06042ab908364773bdca759f9de2c30c...cfa4abb3771e46238b5a6e248f480d0c/)
Buildkite builds:
[Finished] [`e7a9b29b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2991)
[Finished] [`e7a9b29b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3027)
[Finished] [`e7a9b29b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2992)
[Failed] [`e7a9b29b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3017)
[Finished] [`745fa94f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2990)
[Finished] [`745fa94f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3026)
[Finished] [`745fa94f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2991)
[Failed] [`745fa94f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3016)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578809022
I'm just going to take this opportunity and disable flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578823302
@github-actions crossbow submit verify-rc-source-java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on code in PR #35940:
URL: https://github.com/apache/arrow/pull/35940#discussion_r1219902734
##########
dev/release/verify-release-candidate.sh:
##########
@@ -563,7 +563,10 @@ test_package_java() {
show_header "Build and test Java libraries"
# Build and test Java (Requires newer Maven -- I used 3.3.9)
- maybe_setup_conda maven || exit 1
+ # Pin OpenJDK 17 since OpenJDK 20 is incompatible with our versions
+ # of things like Mockito, and we also can't update Mockito due to
+ # not supporting Java 8 anymore
+ maybe_setup_conda maven openjdk=17.0.3 || exit 1
Review Comment:
Won't be also needed to verify also with JDK 8, 11 and 18?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578899946
CI is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "davisusanibar (via GitHub)" <gi...@apache.org>.
davisusanibar commented on code in PR #35940:
URL: https://github.com/apache/arrow/pull/35940#discussion_r1219935432
##########
dev/release/verify-release-candidate.sh:
##########
@@ -563,7 +563,10 @@ test_package_java() {
show_header "Build and test Java libraries"
# Build and test Java (Requires newer Maven -- I used 3.3.9)
- maybe_setup_conda maven || exit 1
+ # Pin OpenJDK 17 since OpenJDK 20 is incompatible with our versions
+ # of things like Mockito, and we also can't update Mockito due to
+ # not supporting Java 8 anymore
+ maybe_setup_conda maven openjdk=17.0.3 || exit 1
Review Comment:
Just filled https://github.com/apache/arrow/issues/35951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578731223
Revision: 5c9206716547808e68f338b4e38f80414daf4e90
Submitted crossbow builds: [ursacomputing/crossbow @ actions-be53c983f5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-be53c983f5)
|Task|Status|
|----|------|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5188884653/jobs/9353114255)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5188885129/jobs/9353115388)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5188885115/jobs/9353115318)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5188884151/jobs/9353113129)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5188884422/jobs/9353113559)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578748909
hmm, that's a new failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578726457
@github-actions crossbow submit verify-rc-source-java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578774209
Revision: 7c6905cc881ba4c081d8ca7ec0a14b375fd7987b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-787ecc1359](https://github.com/ursacomputing/crossbow/branches/all?query=actions-787ecc1359)
|Task|Status|
|----|------|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189164574/jobs/9353772613)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189165316/jobs/9353774654)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189164920/jobs/9353773601)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189165509/jobs/9353775201)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5189165132/jobs/9353774159)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #35940:
URL: https://github.com/apache/arrow/pull/35940#discussion_r1219916112
##########
dev/release/verify-release-candidate.sh:
##########
@@ -563,7 +563,10 @@ test_package_java() {
show_header "Build and test Java libraries"
# Build and test Java (Requires newer Maven -- I used 3.3.9)
- maybe_setup_conda maven || exit 1
+ # Pin OpenJDK 17 since OpenJDK 20 is incompatible with our versions
+ # of things like Mockito, and we also can't update Mockito due to
+ # not supporting Java 8 anymore
+ maybe_setup_conda maven openjdk=17.0.3 || exit 1
Review Comment:
The verification script only ever verified with one version of Java before. We can file a separate task if you want to verify for multiple versions within the script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #35940: GH-35932: [Java] Make JDBC test less brittle
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35940:
URL: https://github.com/apache/arrow/pull/35940#issuecomment-1578768358
@github-actions crossbow submit verify-rc-source-java*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org