You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2023/02/09 13:30:26 UTC

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19487


Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................

IMPALA-11869: Use to_string() in PrintValue for printing Thrift types

IMPALA-11645 introduced the function PrintValue() which we use to
convert Thrift types to strings. This function now uses operator<<,
which is provided for the generated Thrift types. However, Thrift also
generates a to_string() function that is overloaded for Thrift types. It
would be more efficient to use this instead of involving streams with
operator<<.

This change reimplements PrintValue() using to_string() instead of
operator<<.

Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
---
M be/src/util/debug-util.h
1 file changed, 3 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/19487/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Good idea!

http://gerrit.cloudera.org:8080/#/c/19487/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19487/1//COMMIT_MSG@10
PS1, Line 10: now uses
nit: "used" would be more clear in my opinion, since it describes the previous implementation.



-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 10:34:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9043/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 12:16:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9043/


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 17:25:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9062/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 11:50:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 11:50:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19487/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19487/1//COMMIT_MSG@10
PS1, Line 10: used ope
> nit: "used" would be more clear in my opinion, since it describes the previ
Thanks, done.



-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 11:00:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Feb 2023 18:35:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................

IMPALA-11869: Use to_string() in PrintValue for printing Thrift types

IMPALA-11645 introduced the function PrintValue() which we use to
convert Thrift types to strings. This function used operator<<,
which is provided for the generated Thrift types. However, Thrift also
generates a to_string() function that is overloaded for Thrift types. It
would be more efficient to use this instead of involving streams with
operator<<.

This change reimplements PrintValue() using to_string() instead of
operator<<.

Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
---
M be/src/util/debug-util.h
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/19487/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12350/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 11:21:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 12:16:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 12:00:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9040/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Feb 2023 13:31:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12345/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Feb 2023 13:53:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................

IMPALA-11869: Use to_string() in PrintValue for printing Thrift types

IMPALA-11645 introduced the function PrintValue() which we use to
convert Thrift types to strings. This function used operator<<,
which is provided for the generated Thrift types. However, Thrift also
generates a to_string() function that is overloaded for Thrift types. It
would be more efficient to use this instead of involving streams with
operator<<.

This change reimplements PrintValue() using to_string() instead of
operator<<.

Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Reviewed-on: http://gerrit.cloudera.org:8080/19487
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/debug-util.h
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>

[Impala-ASF-CR] IMPALA-11869: Use to string() in PrintValue for printing Thrift types

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19487 )

Change subject: IMPALA-11869: Use to_string() in PrintValue for printing Thrift types
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19487
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5b847dea2bdea7ba0ab8e093a8bab5a8145019
Gerrit-Change-Number: 19487
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 16:56:05 +0000
Gerrit-HasComments: No