You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/01/29 03:18:39 UTC
Review Request 42940: Removed command-line flags from 'logging.md'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42940/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4298
https://issues.apache.org/jira/browse/MESOS-4298
Repository: mesos
Description
-------
Removed command-line flags from 'logging.md'.
Documentation for these flags were moved back to 'configuration.md' in order to keep all command-line flag documentation in one place.
Diffs
-----
docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6
Diff: https://reviews.apache.org/r/42940/diff/
Testing
-------
Viewed with the mesos website container: https://github.com/mesosphere/mesos-website-container
Thanks,
Greg Mann
Re: Review Request 42940: Removed command-line flags from
'logging.md'.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42940/#review116896
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42939, 42940]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 29, 2016, 2:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42940/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 2:18 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed command-line flags from 'logging.md'.
>
> Documentation for these flags were moved back to 'configuration.md' in order to keep all command-line flag documentation in one place.
>
>
> Diffs
> -----
>
> docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6
>
> Diff: https://reviews.apache.org/r/42940/diff/
>
>
> Testing
> -------
>
> Viewed with the mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 42940: Removed command-line flags from
'logging.md'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42940/#review117001
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 29, 2016, 2:18 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42940/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 2:18 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4298
> https://issues.apache.org/jira/browse/MESOS-4298
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed command-line flags from 'logging.md'.
>
> Documentation for these flags were moved back to 'configuration.md' in order to keep all command-line flag documentation in one place.
>
>
> Diffs
> -----
>
> docs/logging.md d79a74708775e5dc01df559042cdf790dfd20bd6
>
> Diff: https://reviews.apache.org/r/42940/diff/
>
>
> Testing
> -------
>
> Viewed with the mesos website container: https://github.com/mesosphere/mesos-website-container
>
>
> Thanks,
>
> Greg Mann
>
>