You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by lujinhong <gi...@git.apache.org> on 2016/03/04 15:56:36 UTC
[GitHub] storm pull request: add private constructor to KafkaUtils
GitHub user lujinhong opened a pull request:
https://github.com/apache/storm/pull/1186
add private constructor to KafkaUtils
Since all of the methods and fields are static, I think it is a good idea to add a private constructor to KafkaUtils to avoid been constructed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lujinhong/storm private_constructor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1186
----
commit 27a724e2f232d5bcf22ce00ecc0090bbba0bb3ed
Author: jinhong-lu <lu...@163.com>
Date: 2016-03-04T14:53:06Z
add private constructor for Utils class
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: add private constructor to KafkaUtils
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: add private constructor to KafkaUtils
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/1186#issuecomment-201028459
+1. Not really necessary, but fine with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---