You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "bereng (via GitHub)" <gi...@apache.org> on 2023/03/01 06:29:22 UTC
[GitHub] [cassandra] bereng commented on a diff in pull request #1891: Cassandra 14227 trunk
bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1121212598
##########
test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java:
##########
@@ -637,18 +637,18 @@ public void testGenerateSstables() throws Throwable
File ksDir = new File(LEGACY_SSTABLE_ROOT, String.format("%s/legacy_tables", BigFormat.latestVersion));
ksDir.tryCreateDirectories();
- copySstablesFromTestData(String.format("legacy_%s_simple", BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_simple_counter", BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust", BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust_counter", BigFormat.latestVersion), ksDir);
+ copySstablesFromTestData(String.format("legacy_%s_simple", BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_simple_counter", BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust", BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust_counter", BigFormat.latestVersion), ksDir, "legacy_tables");
}
- public static void copySstablesFromTestData(String table, File ksDir) throws IOException
+ public static void copySstablesFromTestData(String table, File ksDir, String ks) throws IOException
Review Comment:
I like the static constant. But I would like to leave the method as it is. The new param allows other junits to 'capture' sstables whereas before it only worked for a specific KS. It's one of the changes I need to produce and capture corrupted sstables for the `CompactionsCQLTest` and to make the commented out sample code in there work. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org