You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "Akshat-Soni02 (via GitHub)" <gi...@apache.org> on 2025/09/08 15:44:14 UTC

[PR] FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release [fineract]

Akshat-Soni02 opened a new pull request, #5021:
URL: https://github.com/apache/fineract/pull/5021

   …eases
   
   ## Description
   
   This PR updates the DockerHub publishing workflow (`publish-dockerhub.yml`) to improve tag naming:
   
   - For builds from the `develop` branch → publish image with the `latest` tag.  
   - For builds from release tags (`1.*`) → publish image with the version number only.  
   - Removes publishing of commit hashes and the `develop` tag.  
   
   This change makes the "Recent tags" dropdown on DockerHub more understandable for end users.
   
   ## Checklist
   
   - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests  
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.  
   - [ ] Create/update unit or integration tests for verifying the changes made. *(Not applicable — workflow change only)*  
   - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.  
   - [ ] Add required Swagger annotation and update API documentation at `fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm` with details of any API changes. *(Not applicable — no API change)*  
   - [x] Submission is not a "code dump".  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5021:
URL: https://github.com/apache/fineract/pull/5021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5021:
URL: https://github.com/apache/fineract/pull/5021#issuecomment-3267720589

   @Akshat-Soni02 
   Execution failed for task ':spotlessMiscCheck'.
   > The following files had format violations:
         .github/workflows/publish-dockerhub.yml
             @@ -41,7 +41,7 @@
              ··········else
              ············TAGS="${{·github.ref_name·}}"
              ··········fi
             -··········
             +
              ··········./gradlew·--no-daemon·--console=plain·:fineract-provider:jib·-x·test·-x·cucumber·\
              ············-Djib.to.auth.username=${{secrets.DOCKERHUB_USER}}·\
              ············-Djib.to.auth.***
     Run './gradlew :spotlessApply' to fix these violations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5021:
URL: https://github.com/apache/fineract/pull/5021#issuecomment-3267649593

   @Akshat-Soni02 Please change the commit message to match with the PR title:
   `FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release [fineract]

Posted by "Akshat-Soni02 (via GitHub)" <gi...@apache.org>.
Akshat-Soni02 commented on PR #5021:
URL: https://github.com/apache/fineract/pull/5021#issuecomment-3267693970

   > @Akshat-Soni02 Please change the commit message to match with the PR title: `FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release`
   
   commit message updated, please take a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2350: Fix DockerHub tags, use 'latest' for develop and version tags for release [fineract]

Posted by "Akshat-Soni02 (via GitHub)" <gi...@apache.org>.
Akshat-Soni02 commented on PR #5021:
URL: https://github.com/apache/fineract/pull/5021#issuecomment-3275629058

   > @Akshat-Soni02 Execution failed for task ':spotlessMiscCheck'.
   > 
   > > The following files had format violations:
   > > .github/workflows/publish-dockerhub.yml
   > > @@ -41,7 +41,7 @@
   > > ··········else
   > > ············TAGS="${{·github.ref_name·}}"
   > > ··········fi
   > > -··········
   > > +
   > > ··········./gradlew·--no-daemon·--console=plain·:fineract-provider:jib·-x·test·-x·cucumber·
   > >            ············-Djib.to.auth.username=${{secrets.DOCKERHUB_USER}}·
   > >            ············-Djib.to.auth.***
   > > Run './gradlew :spotlessApply' to fix these violations.
   
   fixed spotless formatting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org