[GitHub] [hudi] yanghua commented on a change in pull request #1920: [HUDI-1150]Fix unable to parse input partition field :1 exception whe…

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #1920:
URL: https://github.com/apache/hudi/pull/1920#discussion_r471267293



##########
File path: hudi-spark/src/main/java/org/apache/hudi/keygen/TimestampBasedKeyGenerator.java
##########
@@ -170,6 +173,32 @@ public String getPartitionPath(GenericRecord record) {
     }
   }
 
+  /**
+   * Set default value to partitionVal if the input value of partitionPathField is null.
+   */
+  private Object getDefaultPartitionVal() {
+    Object result = 1L;

Review comment:
       If you define a variable named `result`, then stop using `return` statement in the middle of the method body. Please set the value of the variable and return it at the end of the method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org