You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/10 13:41:27 UTC

[GitHub] [rocketmq] ShadowySpirits commented on pull request #5503: invert dependency between remoting and common module

ShadowySpirits commented on PR #5503:
URL: https://github.com/apache/rocketmq/pull/5503#issuecomment-1310298486

   > The class `ServiceThread` is repeated.
   
   we can not remove org.apache.rocketmq.remoting.common.ServiceThread for now because dledger depends on it. I removed all uses of it in RocketMQ, and this duplicate class will be removed in the next pr after fixing dledger.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org