[GitHub] [tvm] guberti commented on pull request #13347: [TIR] Fix extern_primfunc buffer order bug

[GitBox <gi...@apache.org>]

guberti commented on PR #13347:
URL: https://github.com/apache/tvm/pull/13347#issuecomment-1310146323

   I'd love to add a unit test to prevent regressions - ideally in `tests/python/unittest/test_tir_te_extern_primfunc.py`. However, when running on `main` I can't get that unit test to pass. I get:
   ```
   ============================================== ERRORS ===============================================
   _______________ ERROR collecting tests/python/unittest/test_tir_te_extern_primfunc.py _______________
   tests/python/unittest/test_tir_te_extern_primfunc.py:36: in <module>
       def func_1(A: T.Buffer[(16,), "float32"], C: T.Buffer[(1,), "float32"]):
   python/tvm/script/tir/prim_func.py:40: in prim_func
       result = from_source(input_func)
   python/tvm/script/parser.py:1368: in from_source
       result = to_ast(input_func, TVMDiagnosticCtx(), parser)
   ../.local/lib/python3.8/site-packages/synr/compiler.py:731: in to_ast
       prog = compiler.compile_module(program_ast)
   ../.local/lib/python3.8/site-packages/synr/compiler.py:100: in compile_module
       new_func = self.compile_def(stmt)
   ../.local/lib/python3.8/site-packages/synr/compiler.py:174: in compile_def
       params = self.compile_args_to_params(args)
   ../.local/lib/python3.8/site-packages/synr/compiler.py:164: in compile_args_to_params
       ty = self.compile_type(arg.annotation)
   ../.local/lib/python3.8/site-packages/synr/compiler.py:622: in compile_type
       return self._expr2type(self.compile_expr(ty))
   ../.local/lib/python3.8/site-packages/synr/compiler.py:605: in _expr2type
       assert isinstance(
   E   AssertionError: Expected subscript call to have lhs of Var, but it is <class 'synr.ast.Attr'>
   ```
   Perhaps I'm building TVM wrong?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org