You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/19 12:26:01 UTC

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #219: Fix some flaws found in demo cluster

hanahmily opened a new pull request, #219:
URL: https://github.com/apache/skywalking-banyandb/pull/219

   - Tweak log default settings
   - Add a default value to the absent field
   - Replace bluge with a variant from zinclab. The new lib is supported by an active community.  
   
   Signed-off-by: Gao Hongtao <ha...@gmail.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #219: Fix some flaws found in demo cluster

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #219:
URL: https://github.com/apache/skywalking-banyandb/pull/219#issuecomment-1320875948

   # [Codecov](https://codecov.io/gh/apache/skywalking-banyandb/pull/219?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#219](https://codecov.io/gh/apache/skywalking-banyandb/pull/219?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a9ecf2) into [main](https://codecov.io/gh/apache/skywalking-banyandb/commit/78d16b75862261e80900d8a0dde3c3de1ce90d14?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (78d16b7) will **decrease** coverage by `0.02%`.
   > The diff coverage is `9.52%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main     #219      +/-   ##
   ==========================================
   - Coverage   43.78%   43.75%   -0.03%     
   ==========================================
     Files          87       87              
     Lines        8590     8593       +3     
   ==========================================
   - Hits         3761     3760       -1     
   - Misses       4491     4495       +4     
     Partials      338      338              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking-banyandb/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [banyand/liaison/grpc/discovery.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvZGlzY292ZXJ5Lmdv) | `11.11% <0.00%> (ø)` | |
   | [banyand/liaison/grpc/measure.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvbWVhc3VyZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [banyand/liaison/grpc/stream.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9saWFpc29uL2dycGMvc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | |
   | [banyand/measure/measure\_query.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21lYXN1cmVfcXVlcnkuZ28=) | `0.00% <0.00%> (ø)` | |
   | [banyand/stream/stream\_query.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9zdHJlYW0vc3RyZWFtX3F1ZXJ5Lmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/encoding/plain.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2VuY29kaW5nL3BsYWluLmdv) | `0.00% <0.00%> (ø)` | |
   | [...ry/logical/measure/measure\_plan\_indexscan\_local.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3F1ZXJ5L2xvZ2ljYWwvbWVhc3VyZS9tZWFzdXJlX3BsYW5faW5kZXhzY2FuX2xvY2FsLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/encoding/int.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2VuY29kaW5nL2ludC5nbw==) | `80.98% <100.00%> (+0.70%)` | :arrow_up: |
   | [banyand/measure/measure.go](https://codecov.io/gh/apache/skywalking-banyandb/pull/219/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZWFzdXJlL21lYXN1cmUuZ28=) | `80.76% <0.00%> (-3.85%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-banyandb] wu-sheng merged pull request #219: Fix some flaws found in demo cluster

Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #219:
URL: https://github.com/apache/skywalking-banyandb/pull/219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org