You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Ruslan Ermilov (JIRA)" <ji...@apache.org> on 2008/09/18 14:43:44 UTC
[jira] Created: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
[patch] native library build script uses unportable sed(1) regexp's
-------------------------------------------------------------------
Key: HADOOP-4201
URL: https://issues.apache.org/jira/browse/HADOOP-4201
Project: Hadoop Core
Issue Type: Improvement
Components: build
Affects Versions: 0.18.0
Environment: FreeBSD 7.0-STABLE amd64
Reporter: Ruslan Ermilov
The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
diff --exclude=CVS --exclude=.svn -rup hadoop-0.18.0~/src/native/acinclude.m4 hadoop-0.18.0/src/native/acinclude.m4
--- hadoop-0.18.0~/src/native/acinclude.m4 2008-08-14 19:48:24.000000000 +0000
+++ hadoop-0.18.0/src/native/acinclude.m4 2008-09-11 12:17:13.412458975 +0000
@@ -10,9 +10,9 @@ AC_CACHE_CHECK([Checking for the 'actual
if test -z "`${CC} ${LDFLAGS} -o conftest conftest.c -l$1 2>&1`"; then
dnl Try objdump and ldd in that order to get the dynamic library
if test ! -z "`which objdump | grep -v 'no objdump'`"; then
- ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/\W*NEEDED\W*\(.*\)\W*$/\"\1\"/'`"
+ ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/[[[[:space:]]]]*NEEDED[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*$/\
"\1\"/'`"
elif test ! -z "`which ldd | grep -v 'no ldd'`"; then
- ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[^A-Za-z0-9]]]*\([[[A-Za-z0-9\.]]]*\)[[[^A-Za-z0-9]]]*=>.*$/\"\1\"/'`"
+ ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*=>.*$/\"\1\"/'`"
else
AC_MSG_ERROR(Can't find either 'objdump' or 'ldd' to compute the dynamic library for '-l$1')
fi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637047#action_12637047 ]
Ruslan Ermilov commented on HADOOP-4201:
----------------------------------------
I've attached a patch file that should pass QA, but I cannot flag the issue's state to "Patch Available".
How to proceed further?
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
> Attachments: hadoop-0.18.0.patch, HADOOP-4201.patch
>
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ermilov updated HADOOP-4201:
-----------------------------------
Status: Patch Available (was: Open)
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
> Attachments: hadoop-0.18.0.patch
>
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ermilov updated HADOOP-4201:
-----------------------------------
Status: Patch Available (was: Open)
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
> diff --exclude=CVS --exclude=.svn -rup hadoop-0.18.0~/src/native/acinclude.m4 hadoop-0.18.0/src/native/acinclude.m4
> --- hadoop-0.18.0~/src/native/acinclude.m4 2008-08-14 19:48:24.000000000 +0000
> +++ hadoop-0.18.0/src/native/acinclude.m4 2008-09-11 12:17:13.412458975 +0000
> @@ -10,9 +10,9 @@ AC_CACHE_CHECK([Checking for the 'actual
> if test -z "`${CC} ${LDFLAGS} -o conftest conftest.c -l$1 2>&1`"; then
> dnl Try objdump and ldd in that order to get the dynamic library
> if test ! -z "`which objdump | grep -v 'no objdump'`"; then
> - ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/\W*NEEDED\W*\(.*\)\W*$/\"\1\"/'`"
> + ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/[[[[:space:]]]]*NEEDED[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*$/\
> "\1\"/'`"
> elif test ! -z "`which ldd | grep -v 'no ldd'`"; then
> - ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[^A-Za-z0-9]]]*\([[[A-Za-z0-9\.]]]*\)[[[^A-Za-z0-9]]]*=>.*$/\"\1\"/'`"
> + ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*=>.*$/\"\1\"/'`"
> else
> AC_MSG_ERROR(Can't find either 'objdump' or 'ldd' to compute the dynamic library for '-l$1')
> fi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632474#action_12632474 ]
Hadoop QA commented on HADOOP-4201:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390371/hadoop-0.18.0.patch
against trunk revision 696846.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3308/console
This message is automatically generated.
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
> Attachments: hadoop-0.18.0.patch
>
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ermilov updated HADOOP-4201:
-----------------------------------
Attachment: HADOOP-4201.patch
Regenerated patch against trunk.
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
> Attachments: hadoop-0.18.0.patch, HADOOP-4201.patch
>
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ermilov updated HADOOP-4201:
-----------------------------------
Attachment: hadoop-0.18.0.patch
A patch.
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
> Attachments: hadoop-0.18.0.patch
>
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ermilov updated HADOOP-4201:
-----------------------------------
Description:
The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
was:
The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
diff --exclude=CVS --exclude=.svn -rup hadoop-0.18.0~/src/native/acinclude.m4 hadoop-0.18.0/src/native/acinclude.m4
--- hadoop-0.18.0~/src/native/acinclude.m4 2008-08-14 19:48:24.000000000 +0000
+++ hadoop-0.18.0/src/native/acinclude.m4 2008-09-11 12:17:13.412458975 +0000
@@ -10,9 +10,9 @@ AC_CACHE_CHECK([Checking for the 'actual
if test -z "`${CC} ${LDFLAGS} -o conftest conftest.c -l$1 2>&1`"; then
dnl Try objdump and ldd in that order to get the dynamic library
if test ! -z "`which objdump | grep -v 'no objdump'`"; then
- ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/\W*NEEDED\W*\(.*\)\W*$/\"\1\"/'`"
+ ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/[[[[:space:]]]]*NEEDED[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*$/\
"\1\"/'`"
elif test ! -z "`which ldd | grep -v 'no ldd'`"; then
- ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[^A-Za-z0-9]]]*\([[[A-Za-z0-9\.]]]*\)[[[^A-Za-z0-9]]]*=>.*$/\"\1\"/'`"
+ ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*=>.*$/\"\1\"/'`"
else
AC_MSG_ERROR(Can't find either 'objdump' or 'ldd' to compute the dynamic library for '-l$1')
fi
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ermilov updated HADOOP-4201:
-----------------------------------
Status: Open (was: Patch Available)
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
> diff --exclude=CVS --exclude=.svn -rup hadoop-0.18.0~/src/native/acinclude.m4 hadoop-0.18.0/src/native/acinclude.m4
> --- hadoop-0.18.0~/src/native/acinclude.m4 2008-08-14 19:48:24.000000000 +0000
> +++ hadoop-0.18.0/src/native/acinclude.m4 2008-09-11 12:17:13.412458975 +0000
> @@ -10,9 +10,9 @@ AC_CACHE_CHECK([Checking for the 'actual
> if test -z "`${CC} ${LDFLAGS} -o conftest conftest.c -l$1 2>&1`"; then
> dnl Try objdump and ldd in that order to get the dynamic library
> if test ! -z "`which objdump | grep -v 'no objdump'`"; then
> - ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/\W*NEEDED\W*\(.*\)\W*$/\"\1\"/'`"
> + ac_cv_libname_$1="`objdump -p conftest | grep NEEDED | grep $1 | sed 's/[[[[:space:]]]]*NEEDED[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*$/\
> "\1\"/'`"
> elif test ! -z "`which ldd | grep -v 'no ldd'`"; then
> - ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[^A-Za-z0-9]]]*\([[[A-Za-z0-9\.]]]*\)[[[^A-Za-z0-9]]]*=>.*$/\"\1\"/'`"
> + ac_cv_libname_$1="`ldd conftest | grep $1 | sed 's/^[[[[:space:]]]]*\([[[^[:space:]]]]*\)[[[[:space:]]]]*=>.*$/\"\1\"/'`"
> else
> AC_MSG_ERROR(Can't find either 'objdump' or 'ldd' to compute the dynamic library for '-l$1')
> fi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4201) [patch] native library build script
uses unportable sed(1) regexp's
Posted by "Ruslan Ermilov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruslan Ermilov updated HADOOP-4201:
-----------------------------------
Status: In Progress (was: Patch Available)
> [patch] native library build script uses unportable sed(1) regexp's
> -------------------------------------------------------------------
>
> Key: HADOOP-4201
> URL: https://issues.apache.org/jira/browse/HADOOP-4201
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.18.0
> Environment: FreeBSD 7.0-STABLE amd64
> Reporter: Ruslan Ermilov
> Attachments: hadoop-0.18.0.patch
>
>
> The native library build script uses unportable sed(1) regular expressions, making it impossible to compile a library using non-GNU sed(1).
> In particular, any POSIX-conformant sed(1) implementation will fail. The following patch has been tested to work on both Linux (Ubuntu) and FreeBSD.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.