You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Omer Ozarslan (JIRA)" <ji...@apache.org> on 2019/08/09 17:36:00 UTC

[jira] [Created] (ARROW-6190) Define and declare functions regardless of NDEBUG

Omer Ozarslan created ARROW-6190:
------------------------------------

             Summary: Define and declare functions regardless of NDEBUG
                 Key: ARROW-6190
                 URL: https://issues.apache.org/jira/browse/ARROW-6190
             Project: Apache Arrow
          Issue Type: Bug
          Components: C++
            Reporter: Omer Ozarslan


NDEBUG is not shipped in linker flags, so I got a linker error with release build on FixedSizeBinaryBuilder::UnsafeAppend(util::string_view value) call, since it makes a call to CheckValueSize.

This is somewhat a follow-up of ARROW-2313. I took the same path by removing NDEBUG ifdefs around CheckValueSize definition and declaration.

I applied the same fix to CheckUTF8Initialized as well after grepping the source code for "#ifndef NDEBUG" and figured out it has the same issue.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)