You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by chuxi <gi...@git.apache.org> on 2016/01/19 04:01:20 UTC
[GitHub] phoenix pull request: bugfix: PHOENIX-2454 Upsert with Double.NaN ...
GitHub user chuxi opened a pull request:
https://github.com/apache/phoenix/pull/148
bugfix: PHOENIX-2454 Upsert with Double.NaN returns NumberFormatException
the bug is on the lira: https://issues.apache.org/jira/browse/PHOENIX-2454
I met the problem when some value in the DataFrame is NaN(Double.NaN and Float.NaN), and it is really important part as storing DataFrame into Phoenix Table.
So can the community merge this PR?
Int, Long, and Short, Byte has no NaN in Scala
It has simple logic inside. I have already did basic test. But maybe someone else could test totally. :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chuxi/phoenix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #148
----
commit 548e07c843d343796f53f783867a92a6a0cf03af
Author: jinhanwei <ji...@growingio.com>
Date: 2016-01-19T02:52:36Z
bugfix: PHOENIX-2454 Upsert with Double.NaN returns NumberFormatException
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: bugfix: PHOENIX-2454 Upsert with Double.NaN ...
Posted by chuxi <gi...@git.apache.org>.
Github user chuxi commented on the pull request:
https://github.com/apache/phoenix/pull/148#issuecomment-172724839
the test.
<img width="493" alt="screen shot 2016-01-19 at 11 08 23 am" src="https://cloud.githubusercontent.com/assets/5573798/12408604/01141ae2-be9d-11e5-9e52-7876f734dcfa.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request #148: bugfix: PHOENIX-2454 Upsert with Double.NaN retur...
Posted by chuxi <gi...@git.apache.org>.
Github user chuxi closed the pull request at:
https://github.com/apache/phoenix/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---