You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/05/19 16:20:46 UTC
Patch missing in 4.4-forward
Hi,
The patch related to feature "Volume Provisioning" (
https://reviews.apache.org/r/19446/) is not present in 4.4-forward branch,
it is committed to only master.
Is this intended? If not can you push it to 4.4-forward too?
Don't know how but the unit tests related to this feature are present in
4.4-forward branch and are failing in the daily run. I think until this
patch comes into forward branch, we should disable the related tests.
Regards,
Gaurav
Re: Patch missing in 4.4-forward
Posted by Gaurav Aradhye <ga...@clogeny.com>.
Yes. Integration smoke test.
Regards,
Gaurav
On Tue, May 20, 2014 at 1:52 PM, Daan Hoogland <da...@gmail.com>wrote:
> Gaurav, to avoid confusion: these look like integration tests. Is that
> what you mean?
>
> On Tue, May 20, 2014 at 7:17 AM, Gaurav Aradhye
> <ga...@clogeny.com> wrote:
> > Hello Yoshikazu,
> >
> > Please take a look at this patch (https://reviews.apache.org/r/21682/).
> > These are the unit tests I am talking about. These should not be present
> in
> > 4.4-forward right?
> >
> > Regards,
> > Gaurav
> >
> >
> > On Mon, May 19, 2014 at 8:28 PM, Yoshikazu Nojima <ma...@ynojima.net>
> wrote:
> >
> >> Gaurav,
> >>
> >> This patch is intended to be released in 4.5 release, because when I
> >> wrote up it, 4.4 feature freeze date was already passed.
> >> I'm not sure which unit test are you talking about?
> >>
> >> Regards,
> >> Noji
> >>
> >>
> >>
> >> 2014-05-19 8:20 GMT-06:00 Gaurav Aradhye <ga...@clogeny.com>:
> >> > Hi,
> >> >
> >> > The patch related to feature "Volume Provisioning"
> >> > (https://reviews.apache.org/r/19446/) is not present in 4.4-forward
> >> branch,
> >> > it is committed to only master.
> >> >
> >> > Is this intended? If not can you push it to 4.4-forward too?
> >> >
> >> > Don't know how but the unit tests related to this feature are present
> in
> >> > 4.4-forward branch and are failing in the daily run. I think until
> this
> >> > patch comes into forward branch, we should disable the related tests.
> >> >
> >> > Regards,
> >> > Gaurav
> >>
>
>
>
> --
> Daan
>
RE: Patch missing in 4.4-forward
Posted by Santhosh Edukulla <sa...@citrix.com>.
Below mentioned tests were already disabled under 4.4-forward.
Santhosh
________________________________________
From: Min Chen
Sent: Tuesday, May 20, 2014 12:26 PM
To: dev@cloudstack.apache.org
Cc: Yoshikazu Nojima; Marcus Sorensen; Rayees Namathponnan; Santhosh Edukulla
Subject: Re: Patch missing in 4.4-forward
I ran into same issues in analyzing automation test. The related
integration tests are merged into 4.4-forward along with marvin test
framework merge, but this patch does not exist in 4.4-forward, so we
should either disable these two integration tests, or pull that patch code
into 4.4-forward.
Thanks
-min
On 5/20/14 1:22 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>Gaurav, to avoid confusion: these look like integration tests. Is that
>what you mean?
>
>On Tue, May 20, 2014 at 7:17 AM, Gaurav Aradhye
><ga...@clogeny.com> wrote:
>> Hello Yoshikazu,
>>
>> Please take a look at this patch (https://reviews.apache.org/r/21682/).
>> These are the unit tests I am talking about. These should not be
>>present in
>> 4.4-forward right?
>>
>> Regards,
>> Gaurav
>>
>>
>> On Mon, May 19, 2014 at 8:28 PM, Yoshikazu Nojima <ma...@ynojima.net>
>>wrote:
>>
>>> Gaurav,
>>>
>>> This patch is intended to be released in 4.5 release, because when I
>>> wrote up it, 4.4 feature freeze date was already passed.
>>> I'm not sure which unit test are you talking about?
>>>
>>> Regards,
>>> Noji
>>>
>>>
>>>
>>> 2014-05-19 8:20 GMT-06:00 Gaurav Aradhye <ga...@clogeny.com>:
>>> > Hi,
>>> >
>>> > The patch related to feature "Volume Provisioning"
>>> > (https://reviews.apache.org/r/19446/) is not present in 4.4-forward
>>> branch,
>>> > it is committed to only master.
>>> >
>>> > Is this intended? If not can you push it to 4.4-forward too?
>>> >
>>> > Don't know how but the unit tests related to this feature are
>>>present in
>>> > 4.4-forward branch and are failing in the daily run. I think until
>>>this
>>> > patch comes into forward branch, we should disable the related tests.
>>> >
>>> > Regards,
>>> > Gaurav
>>>
>
>
>
>--
>Daan
Re: Patch missing in 4.4-forward
Posted by Min Chen <mi...@citrix.com>.
I ran into same issues in analyzing automation test. The related
integration tests are merged into 4.4-forward along with marvin test
framework merge, but this patch does not exist in 4.4-forward, so we
should either disable these two integration tests, or pull that patch code
into 4.4-forward.
Thanks
-min
On 5/20/14 1:22 AM, "Daan Hoogland" <da...@gmail.com> wrote:
>Gaurav, to avoid confusion: these look like integration tests. Is that
>what you mean?
>
>On Tue, May 20, 2014 at 7:17 AM, Gaurav Aradhye
><ga...@clogeny.com> wrote:
>> Hello Yoshikazu,
>>
>> Please take a look at this patch (https://reviews.apache.org/r/21682/).
>> These are the unit tests I am talking about. These should not be
>>present in
>> 4.4-forward right?
>>
>> Regards,
>> Gaurav
>>
>>
>> On Mon, May 19, 2014 at 8:28 PM, Yoshikazu Nojima <ma...@ynojima.net>
>>wrote:
>>
>>> Gaurav,
>>>
>>> This patch is intended to be released in 4.5 release, because when I
>>> wrote up it, 4.4 feature freeze date was already passed.
>>> I'm not sure which unit test are you talking about?
>>>
>>> Regards,
>>> Noji
>>>
>>>
>>>
>>> 2014-05-19 8:20 GMT-06:00 Gaurav Aradhye <ga...@clogeny.com>:
>>> > Hi,
>>> >
>>> > The patch related to feature "Volume Provisioning"
>>> > (https://reviews.apache.org/r/19446/) is not present in 4.4-forward
>>> branch,
>>> > it is committed to only master.
>>> >
>>> > Is this intended? If not can you push it to 4.4-forward too?
>>> >
>>> > Don't know how but the unit tests related to this feature are
>>>present in
>>> > 4.4-forward branch and are failing in the daily run. I think until
>>>this
>>> > patch comes into forward branch, we should disable the related tests.
>>> >
>>> > Regards,
>>> > Gaurav
>>>
>
>
>
>--
>Daan
Re: Patch missing in 4.4-forward
Posted by Daan Hoogland <da...@gmail.com>.
Gaurav, to avoid confusion: these look like integration tests. Is that
what you mean?
On Tue, May 20, 2014 at 7:17 AM, Gaurav Aradhye
<ga...@clogeny.com> wrote:
> Hello Yoshikazu,
>
> Please take a look at this patch (https://reviews.apache.org/r/21682/).
> These are the unit tests I am talking about. These should not be present in
> 4.4-forward right?
>
> Regards,
> Gaurav
>
>
> On Mon, May 19, 2014 at 8:28 PM, Yoshikazu Nojima <ma...@ynojima.net> wrote:
>
>> Gaurav,
>>
>> This patch is intended to be released in 4.5 release, because when I
>> wrote up it, 4.4 feature freeze date was already passed.
>> I'm not sure which unit test are you talking about?
>>
>> Regards,
>> Noji
>>
>>
>>
>> 2014-05-19 8:20 GMT-06:00 Gaurav Aradhye <ga...@clogeny.com>:
>> > Hi,
>> >
>> > The patch related to feature "Volume Provisioning"
>> > (https://reviews.apache.org/r/19446/) is not present in 4.4-forward
>> branch,
>> > it is committed to only master.
>> >
>> > Is this intended? If not can you push it to 4.4-forward too?
>> >
>> > Don't know how but the unit tests related to this feature are present in
>> > 4.4-forward branch and are failing in the daily run. I think until this
>> > patch comes into forward branch, we should disable the related tests.
>> >
>> > Regards,
>> > Gaurav
>>
--
Daan
Re: Patch missing in 4.4-forward
Posted by Gaurav Aradhye <ga...@clogeny.com>.
Hello Yoshikazu,
Please take a look at this patch (https://reviews.apache.org/r/21682/).
These are the unit tests I am talking about. These should not be present in
4.4-forward right?
Regards,
Gaurav
On Mon, May 19, 2014 at 8:28 PM, Yoshikazu Nojima <ma...@ynojima.net> wrote:
> Gaurav,
>
> This patch is intended to be released in 4.5 release, because when I
> wrote up it, 4.4 feature freeze date was already passed.
> I'm not sure which unit test are you talking about?
>
> Regards,
> Noji
>
>
>
> 2014-05-19 8:20 GMT-06:00 Gaurav Aradhye <ga...@clogeny.com>:
> > Hi,
> >
> > The patch related to feature "Volume Provisioning"
> > (https://reviews.apache.org/r/19446/) is not present in 4.4-forward
> branch,
> > it is committed to only master.
> >
> > Is this intended? If not can you push it to 4.4-forward too?
> >
> > Don't know how but the unit tests related to this feature are present in
> > 4.4-forward branch and are failing in the daily run. I think until this
> > patch comes into forward branch, we should disable the related tests.
> >
> > Regards,
> > Gaurav
>
Re: Patch missing in 4.4-forward
Posted by Yoshikazu Nojima <ma...@ynojima.net>.
Gaurav,
This patch is intended to be released in 4.5 release, because when I
wrote up it, 4.4 feature freeze date was already passed.
I'm not sure which unit test are you talking about?
Regards,
Noji
2014-05-19 8:20 GMT-06:00 Gaurav Aradhye <ga...@clogeny.com>:
> Hi,
>
> The patch related to feature "Volume Provisioning"
> (https://reviews.apache.org/r/19446/) is not present in 4.4-forward branch,
> it is committed to only master.
>
> Is this intended? If not can you push it to 4.4-forward too?
>
> Don't know how but the unit tests related to this feature are present in
> 4.4-forward branch and are failing in the daily run. I think until this
> patch comes into forward branch, we should disable the related tests.
>
> Regards,
> Gaurav