You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "xu1009 (via GitHub)" <gi...@apache.org> on 2023/04/25 08:11:08 UTC
[GitHub] [skywalking-java] xu1009 opened a new pull request, #515: test add
xu1009 opened a new pull request, #515:
URL: https://github.com/apache/skywalking-java/pull/515
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. https://github.com/apache/skywalking/issues/10729.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #515: test add
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #515:
URL: https://github.com/apache/skywalking-java/pull/515#issuecomment-1521362766
Is this PR official? I see the title is `test add`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #515: clickhouse-jdbc-plugin support trace sql parameters when enable plugin.jdbc.trace_sql_parameters
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #515:
URL: https://github.com/apache/skywalking-java/pull/515#discussion_r1176211682
##########
apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/define/StatementEnhanceInfos.java:
##########
@@ -38,6 +38,9 @@ public StatementEnhanceInfos(ConnectionInfo connectionInfo, String sql, String s
this.statementName = statementName;
}
+ public StatementEnhanceInfos() {
Review Comment:
Why do you build an empty one? You can't get the necessary information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on pull request #515: clickhouse-jdbc-plugin support trace sql parameters when enable plugin.jdbc.trace_sql_parameters
Posted by "xu1009 (via GitHub)" <gi...@apache.org>.
xu1009 commented on PR #515:
URL: https://github.com/apache/skywalking-java/pull/515#issuecomment-1521390705
sorry, i have changed title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #515: clickhouse-jdbc-plugin support trace sql parameters when enable plugin.jdbc.trace_sql_parameters
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #515:
URL: https://github.com/apache/skywalking-java/pull/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #515: clickhouse-jdbc-plugin support trace sql parameters when enable plugin.jdbc.trace_sql_parameters
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #515:
URL: https://github.com/apache/skywalking-java/pull/515#discussion_r1176217624
##########
apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/define/StatementEnhanceInfos.java:
##########
@@ -38,6 +38,9 @@ public StatementEnhanceInfos(ConnectionInfo connectionInfo, String sql, String s
this.statementName = statementName;
}
+ public StatementEnhanceInfos() {
Review Comment:
Usually, if these information is available, it is better to build in the constructor.
Otherwise, one day, we may face uncertain NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xu1009 commented on a diff in pull request #515: clickhouse-jdbc-plugin support trace sql parameters when enable plugin.jdbc.trace_sql_parameters
Posted by "xu1009 (via GitHub)" <gi...@apache.org>.
xu1009 commented on code in PR #515:
URL: https://github.com/apache/skywalking-java/pull/515#discussion_r1176238151
##########
apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/define/StatementEnhanceInfos.java:
##########
@@ -38,6 +38,9 @@ public StatementEnhanceInfos(ConnectionInfo connectionInfo, String sql, String s
this.statementName = statementName;
}
+ public StatementEnhanceInfos() {
Review Comment:
i can get the information, but it is useless, i just use param set part, ok, i will use the constructor and set information to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org