You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "kishoreg (via GitHub)" <gi...@apache.org> on 2023/01/25 19:21:25 UTC

[GitHub] [pinot] kishoreg commented on a diff in pull request #10179: [multistage][observability] Add an option to log operator stats to log.error

kishoreg commented on code in PR #10179:
URL: https://github.com/apache/pinot/pull/10179#discussion_r1087078350


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -142,9 +144,10 @@ public void processQuery(DistributedStagePlan distributedStagePlan, Map<String,
             new ServerMetrics(PinotMetricUtils.getPinotMetricsRegistry()), System.currentTimeMillis());
         serverQueryResults.add(processServerQuery(request, _scheduler.getWorkerPool()));
       }
-      LOGGER.debug(
-          "RequestId:" + requestId + " StageId:" + distributedStagePlan.getStageId() + " Leaf stage v1 processing time:"
-              + (System.currentTimeMillis() - leafStageStartMillis) + " ms");
+      if (shouldLogOpStats) {
+        LOGGER.error("RequestId:" + requestId + " StageId:" + distributedStagePlan.getStageId()

Review Comment:
   +1 lets put this in info. we can remove this once join is GA



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org