You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mv...@apache.org on 2013/07/16 21:15:24 UTC
svn commit: r1503837 -
/lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
Author: mvg
Date: Tue Jul 16 19:15:24 2013
New Revision: 1503837
URL: http://svn.apache.org/r1503837
Log:
LUCENE-5088: Fixed test
Modified:
lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
Modified: lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java?rev=1503837&r1=1503836&r2=1503837&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java (original)
+++ lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java Tue Jul 16 19:15:24 2013
@@ -123,7 +123,7 @@ public class TermFilterTest extends Luce
String field1 = "field" + i;
String field2 = "field" + i + num;
String value1 = _TestUtil.randomRealisticUnicodeString(random());
- String value2 = _TestUtil.randomRealisticUnicodeString(random());
+ String value2 = _TestUtil.randomRealisticUnicodeString(random()) + "x"; // this must be not equal to value1
TermFilter filter1 = termFilter(field1, value1);
TermFilter filter2 = termFilter(field1, value2);
@@ -139,6 +139,8 @@ public class TermFilterTest extends Luce
assertEquals(termFilter.hashCode(), otherTermFilter.hashCode());
assertTrue(termFilter.equals(otherTermFilter));
} else {
+ System.out.println(termFilter);
+ System.out.println(otherTermFilter);
assertFalse(termFilter.equals(otherTermFilter));
}
}
Re: svn commit: r1503837 - /lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
Posted by Martijn v Groningen <ma...@gmail.com>.
Just did this...
On 16 July 2013 21:19, Uwe Schindler <uw...@thetaphi.de> wrote:
> Hi Martijn,
>
> Maybe remove the System.out?
>
> Uwe
>
>
>
> mvg@apache.org schrieb:
>>
>> Author: mvg
>> Date: Tue Jul 16 19:15:24 2013
>> New Revision: 1503837
>>
>> URL: http://svn.apache.org/r1503837
>> Log:
>> LUCENE-5088: Fixed test
>>
>> Modified:
>> lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
>>
>> Modified: lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java?rev=1503837&r1=1503836&r2=1503837&view=diff
>> ------------------------------
>>
>> --- lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java (original)
>> +++
>> lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java Tue Jul 16 19:15:24 2013
>> @@ -123,7 +123,7 @@ public class TermFilterTest extends Luce
>> String field1 = "field" + i;
>>
>> String field2 = "field" + i + num;
>> String value1 = _TestUtil.randomRealisticUnicodeString(random());
>> - String value2 = _TestUtil.randomRealisticUnicodeString(random());
>> + String value2 = _TestUtil.randomRealisticUnicodeString(random()) + "x"; // this must be not equal to value1
>>
>>
>> TermFilter filter1 = termFilter(field1, value1);
>> TermFilter filter2 = termFilter(field1, value2);
>> @@ -139,6 +139,8 @@ public class TermFilterTest extends Luce
>> assertEquals(termFilter.hashCode(), otherTermFilter.hashCode());
>>
>> assertTrue(termFilter.equals(otherTermFilter));
>> } else {
>> + System.out.println(termFilter);
>> +
>> System.out.println(otherTermFilter);
>> assertFalse(termFilter.equals(otherTermFilter));
>> }
>> }
>>
>>
>>
> --
> Uwe Schindler
> H.-H.-Meier-Allee 63, 28213 Bremen
> http://www.thetaphi.de
>
--
Met vriendelijke groet,
Martijn van Groningen
Re: svn commit: r1503837 - /lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
Posted by Uwe Schindler <uw...@thetaphi.de>.
Hi Martijn,
Maybe remove the System.out?
Uwe
mvg@apache.org schrieb:
>Author: mvg
>Date: Tue Jul 16 19:15:24 2013
>New Revision: 1503837
>
>URL: http://svn.apache.org/r1503837
>Log:
>LUCENE-5088: Fixed test
>
>Modified:
>lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
>
>Modified:
>lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
>URL:
>http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java?rev=1503837&r1=1503836&r2=1503837&view=diff
>==============================================================================
>---
>lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
>(original)
>+++
>lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
>Tue Jul 16 19:15:24 2013
>@@ -123,7 +123,7 @@ public class TermFilterTest extends Luce
> String field1 = "field" + i;
> String field2 = "field" + i + num;
> String value1 = _TestUtil.randomRealisticUnicodeString(random());
>- String value2 =
>_TestUtil.randomRealisticUnicodeString(random());
>+ String value2 = _TestUtil.randomRealisticUnicodeString(random())
>+ "x"; // this must be not equal to value1
>
> TermFilter filter1 = termFilter(field1, value1);
> TermFilter filter2 = termFilter(field1, value2);
>@@ -139,6 +139,8 @@ public class TermFilterTest extends Luce
> assertEquals(termFilter.hashCode(), otherTermFilter.hashCode());
> assertTrue(termFilter.equals(otherTermFilter));
> } else {
>+ System.out.println(termFilter);
>+ System.out.println(otherTermFilter);
> assertFalse(termFilter.equals(otherTermFilter));
> }
> }
--
Uwe Schindler
H.-H.-Meier-Allee 63, 28213 Bremen
http://www.thetaphi.de
Re: svn commit: r1503837 - /lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFi
lterTest.java
Posted by Martijn v Groningen <ma...@gmail.com>.
True, I misunderstood Robert
and_TestUtil#randomRealisticUnicodeString(random). I will change the test.
Thanks for pointing this out to me.
On 16 July 2013 23:12, Chris Hostetter <ho...@fucit.org> wrote:
>
> : This should fix this, b/c value2 (one extra character) will always be
> : different than value1. The test initially failed b/c value1 and value2
> were
> : equal.
>
> rmuir's point is that what you are describing is not garunteed to be true,
> because randomRealisticUnicodeString returns strings of random lengths as
> well (unless you specifiy minLength and maxLength)
>
> The first call to randomRealisticUnicodeString(random()) might set value1
> to "foox" and the second call to randomRealisticUnicodeString(random())
> might return "foo" making the value of value1 "foox" as well.
>
> I think you just want something like: String value2 = value1 + "x"
>
>
>
> : On 16 July 2013 21:37, Robert Muir <rc...@gmail.com> wrote:
> :
> : > Does this really fix this or just make it less likely to happen...?
> : >
> : >
> : > On Tue, Jul 16, 2013 at 12:15 PM, <mv...@apache.org> wrote:
> : >
> : >>
> : >> String value1 =
> _TestUtil.randomRealisticUnicodeString(random());
> : >> - String value2 =
> _TestUtil.randomRealisticUnicodeString(random());
> : >> + String value2 =
> _TestUtil.randomRealisticUnicodeString(random()) +
> : >> "x"; // this must be not equal to value1
> : >>
> : >
> :
> :
> : --
> : Met vriendelijke groet,
> :
> : Martijn van Groningen
> :
>
> -Hoss
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
--
Met vriendelijke groet,
Martijn van Groningen
Re: svn commit: r1503837 - /lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFi
lterTest.java
Posted by Chris Hostetter <ho...@fucit.org>.
: This should fix this, b/c value2 (one extra character) will always be
: different than value1. The test initially failed b/c value1 and value2 were
: equal.
rmuir's point is that what you are describing is not garunteed to be true,
because randomRealisticUnicodeString returns strings of random lengths as
well (unless you specifiy minLength and maxLength)
The first call to randomRealisticUnicodeString(random()) might set value1
to "foox" and the second call to randomRealisticUnicodeString(random())
might return "foo" making the value of value1 "foox" as well.
I think you just want something like: String value2 = value1 + "x"
: On 16 July 2013 21:37, Robert Muir <rc...@gmail.com> wrote:
:
: > Does this really fix this or just make it less likely to happen...?
: >
: >
: > On Tue, Jul 16, 2013 at 12:15 PM, <mv...@apache.org> wrote:
: >
: >>
: >> String value1 = _TestUtil.randomRealisticUnicodeString(random());
: >> - String value2 = _TestUtil.randomRealisticUnicodeString(random());
: >> + String value2 = _TestUtil.randomRealisticUnicodeString(random()) +
: >> "x"; // this must be not equal to value1
: >>
: >
:
:
: --
: Met vriendelijke groet,
:
: Martijn van Groningen
:
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1503837 - /lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
Posted by Martijn v Groningen <ma...@gmail.com>.
This should fix this, b/c value2 (one extra character) will always be
different than value1. The test initially failed b/c value1 and value2 were
equal.
On 16 July 2013 21:37, Robert Muir <rc...@gmail.com> wrote:
> Does this really fix this or just make it less likely to happen...?
>
>
> On Tue, Jul 16, 2013 at 12:15 PM, <mv...@apache.org> wrote:
>
>>
>> String value1 = _TestUtil.randomRealisticUnicodeString(random());
>> - String value2 = _TestUtil.randomRealisticUnicodeString(random());
>> + String value2 = _TestUtil.randomRealisticUnicodeString(random()) +
>> "x"; // this must be not equal to value1
>>
>
--
Met vriendelijke groet,
Martijn van Groningen
Re: svn commit: r1503837 - /lucene/dev/trunk/lucene/queries/src/test/org/apache/lucene/queries/TermFilterTest.java
Posted by Robert Muir <rc...@gmail.com>.
Does this really fix this or just make it less likely to happen...?
On Tue, Jul 16, 2013 at 12:15 PM, <mv...@apache.org> wrote:
>
> String value1 = _TestUtil.randomRealisticUnicodeString(random());
> - String value2 = _TestUtil.randomRealisticUnicodeString(random());
> + String value2 = _TestUtil.randomRealisticUnicodeString(random()) +
> "x"; // this must be not equal to value1
>