[GitHub] [incubator-heron] nwangtw commented on a change in pull request #3282: WIP STREAMCOMP-2724: Stream Manager migrated to mainly use smart pointers instead of a manual memory management

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3282: WIP STREAMCOMP-2724: Stream Manager migrated to mainly use smart pointers instead of a manual memory management
URL: https://github.com/apache/incubator-heron/pull/3282#discussion_r291284833
 
 

 ##########
 File path: heron/instance/src/cpp/boltimpl/bolt-instance.cpp
 ##########
 @@ -35,11 +35,11 @@
 namespace heron {
 namespace instance {
 
-BoltInstance::BoltInstance(EventLoop* eventLoop,
-                           std::shared_ptr<TaskContextImpl> taskContext,
-                           NotifyingCommunicator<google::protobuf::Message*>* dataToSlave,
-                           NotifyingCommunicator<google::protobuf::Message*>* dataFromSlave,
-                           void* dllHandle)
+BoltInstance::BoltInstance(std::shared_ptr<EventLoop> eventLoop,
+                         std::shared_ptr<TaskContextImpl> taskContext,
 
 Review comment:
   indent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services