You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "igarashitm (via GitHub)" <gi...@apache.org> on 2023/08/30 21:21:13 UTC
[GitHub] [camel] igarashitm opened a new pull request, #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
igarashitm opened a new pull request, #11245:
URL: https://github.com/apache/camel/pull/11245
# Description
Removing camel-yaml-dsl.json schema file in favor of camelYamlDsl.json. Also changed schema validation tests to use camelYamlDsl.json
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
https://issues.apache.org/jira/browse/CAMEL-19703
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] igarashitm merged pull request #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm merged PR #11245:
URL: https://github.com/apache/camel/pull/11245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11245:
URL: https://github.com/apache/camel/pull/11245#issuecomment-1701172114
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton commented on pull request #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #11245:
URL: https://github.com/apache/camel/pull/11245#issuecomment-1700835528
Can we update (or remove) the link to the schema in `yaml-dsl.adoc`? See the 'supported EIPs' section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] igarashitm commented on pull request #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm commented on PR #11245:
URL: https://github.com/apache/camel/pull/11245#issuecomment-1700824449
SchemaStore - https://github.com/SchemaStore/schemastore/pull/3178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] igarashitm commented on pull request #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm commented on PR #11245:
URL: https://github.com/apache/camel/pull/11245#issuecomment-1701129540
Added like this, does it look OK?
https://github.com/apache/camel/pull/11245/files#diff-a15c79f82f45a38fd9ce6aceabd27c6c824eb13c738c9f076eb8c197c3dfb0ebR101-R102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #11245:
URL: https://github.com/apache/camel/pull/11245#issuecomment-1700347820
We should add a note in the 4.1 upgrade guide.
Also that website (schema store) that links to our schema needs to be updated also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] igarashitm commented on pull request #11245: [CAMEL-19703] [yaml dsl] remove kebab-case schema definition
Posted by "igarashitm (via GitHub)" <gi...@apache.org>.
igarashitm commented on PR #11245:
URL: https://github.com/apache/camel/pull/11245#issuecomment-1700847230
@jamesnetherton good catch! done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org