You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/07/01 21:27:15 UTC
[GitHub] [solr] epugh opened a new pull request, #926: SOLR-16223: unused throws identified by IntelliJ (round 2)
epugh opened a new pull request, #926:
URL: https://github.com/apache/solr/pull/926
https://issues.apache.org/jira/browse/SOLR-16223
# Description
The first pass through looking for unused Exceptions was by hand, file by file. However IntelliJ flagged many other examples, and I finally learned how to use IntelliJ to automatically fix things.
# Solution
Use IntelliJ.
# Tests
Ran the tests!
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a diff in pull request #926: SOLR-16223: unused throws identified by IntelliJ (round 2)
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on code in PR #926:
URL: https://github.com/apache/solr/pull/926#discussion_r914923118
##########
solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java:
##########
@@ -59,7 +59,7 @@ public static void beforeClassSetup() {
@Test
@Override
@Ignore
- public void test() throws Exception {}
+ public void test() {}
Review Comment:
no-op test, looks like. perhaps there are others elsewhere in the code base too? anyhow, outside the scope of current PR, just caught me eye.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on a diff in pull request #926: SOLR-16223: unused throws identified by IntelliJ (round 2)
Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #926:
URL: https://github.com/apache/solr/pull/926#discussion_r915815261
##########
solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java:
##########
@@ -59,7 +59,7 @@ public static void beforeClassSetup() {
@Test
@Override
@Ignore
- public void test() throws Exception {}
+ public void test() {}
Review Comment:
Good catch...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #926: SOLR-16223: unused throws identified by IntelliJ (round 2)
Posted by GitBox <gi...@apache.org>.
epugh merged PR #926:
URL: https://github.com/apache/solr/pull/926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org