You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/15 16:47:38 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request #3085:
ARTEMIS-2692 update dependency for JMS client
jbertram opened a new pull request #3085: ARTEMIS-2692 update dependency for JMS client
URL: https://github.com/apache/activemq-artemis/pull/3085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull
request #3085: ARTEMIS-2692 update dependency for JMS client
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3085: ARTEMIS-2692 update dependency for JMS client
URL: https://github.com/apache/activemq-artemis/pull/3085#discussion_r409040974
##########
File path: artemis-jms-client/pom.xml
##########
@@ -50,6 +50,11 @@
<artifactId>artemis-core-client</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-commons</artifactId>
Review comment:
Fair enough +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on issue #3085: ARTEMIS-2692
update dependency for JMS client
Posted by GitBox <gi...@apache.org>.
jbertram commented on issue #3085: ARTEMIS-2692 update dependency for JMS client
URL: https://github.com/apache/activemq-artemis/pull/3085#issuecomment-614153658
@clebertsuconic, this should probably be merged before the release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull
request #3085: ARTEMIS-2692 update dependency for JMS client
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #3085: ARTEMIS-2692 update dependency for JMS client
URL: https://github.com/apache/activemq-artemis/pull/3085#discussion_r409022407
##########
File path: artemis-jms-client/pom.xml
##########
@@ -50,6 +50,11 @@
<artifactId>artemis-core-client</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-commons</artifactId>
Review comment:
Why is this needed it comes as a transitive anyhow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3085: ARTEMIS-2692
update dependency for JMS client
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3085: ARTEMIS-2692 update dependency for JMS client
URL: https://github.com/apache/activemq-artemis/pull/3085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] jbertram commented on a change in pull request
#3085: ARTEMIS-2692 update dependency for JMS client
Posted by GitBox <gi...@apache.org>.
jbertram commented on a change in pull request #3085: ARTEMIS-2692 update dependency for JMS client
URL: https://github.com/apache/activemq-artemis/pull/3085#discussion_r409025360
##########
File path: artemis-jms-client/pom.xml
##########
@@ -50,6 +50,11 @@
<artifactId>artemis-core-client</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-commons</artifactId>
Review comment:
Yes, it comes in as transitive, but `org.apache.activemq.artemis.jms.client.ActiveMQDestination` uses `org.apache.activemq.artemis.api.core.QueueConfiguration` (from `artemins-commons`) explicitly so IMO the dependency should be explicit as well instead of leaving it as transitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services