You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/04 17:25:58 UTC

[GitHub] [apisix-dashboard] starsz opened a new pull request #1430: feat: add version match API

starsz opened a new pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   #1165
   
   ### New feature or improvement
   - Describe the details and related test reports.
   
   Add an API to check the version of manger-api and apisix.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773805734


   need more members to review this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570677576



##########
File path: api/internal/handler/tool/tool.go
##########
@@ -48,3 +68,44 @@ func (h *Handler) Version(_ droplet.Context) (interface{}, error) {
 		Version: version,
 	}, nil
 }
+
+func (h *Handler) VersionMatch(c droplet.Context) (interface{}, error) {
+	_, version := utils.GetHashAndVersion()
+	var output VersionMatchOutput
+	output.DashboardVersion = version
+
+	matchedVersion := utils.GetMatchedVersion(version)
+
+	var notMatchedNodes = make([]nodes, 0)
+	_, err := h.serverInfoStore.List(c.Context(), store.ListInput{
+		Predicate: func(obj interface{}) bool {
+			serverInfo := obj.(*entity.ServerInfo)
+
+			if serverInfo.Version != matchedVersion {
+				notMatchedNodes = append(notMatchedNodes, nodes{
+					Hostname: serverInfo.Hostname,
+					Version:  serverInfo.Version,
+				})
+			}
+			return false
+		},
+	})
+
+	if err != nil {
+		return nil, err
+	}
+
+	output.NotMatchedNodes = notMatchedNodes
+	if len(output.NotMatchedNodes) == 0 {
+		output.Matched = true
+	} else {
+		// TODO: move this to utils
+		return &data.SpecCodeResponse{StatusCode: http.StatusOK, Response: data.Response{
+			Data:    &output,
+			Code:    2000001,
+			Message: "The version of manager-api and apisix are not matched.",

Review comment:
       ```suggestion
   			Message: "The manager-api and apache apisix are mismatched.",
   ```

##########
File path: api/internal/handler/tool/tool.go
##########
@@ -17,28 +17,48 @@
 package tool
 
 import (
+	"net/http"
+
 	"github.com/gin-gonic/gin"
 	"github.com/shiningrush/droplet"
+	"github.com/shiningrush/droplet/data"
 	wgin "github.com/shiningrush/droplet/wrapper/gin"
 
+	"github.com/apisix/manager-api/internal/core/entity"
+	"github.com/apisix/manager-api/internal/core/store"
 	"github.com/apisix/manager-api/internal/handler"
 	"github.com/apisix/manager-api/internal/utils"
 )
 
 type Handler struct {
+	serverInfoStore store.Interface
 }
 
 type InfoOutput struct {
 	Hash    string `json:"commit_hash"`
 	Version string `json:"version"`
 }
 
+type nodes struct {
+	Hostname string `json:"hostname"`
+	Version  string `json:"version"`
+}
+
+type VersionMatchOutput struct {
+	Matched          bool    `json:"matched"`
+	DashboardVersion string  `json:"dashboard_version"`
+	NotMatchedNodes  []nodes `json:"not_matched_nodes"`

Review comment:
       recommend using `mismatched_nodes` 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773812399


   > /lgtm
   
   Thank you for your code review. 😄


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570737662



##########
File path: api/internal/utils/consts/versionMap.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package consts
+
+/*
+	Key is dashboard version
+	Val is apisix version
+*/
+var VersionMap = map[string]string{

Review comment:
       Sorry. We can't. Because of `const` type only for boolean, number, string.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570707626



##########
File path: api/internal/handler/tool/tool.go
##########
@@ -17,28 +17,48 @@
 package tool
 
 import (
+	"net/http"
+
 	"github.com/gin-gonic/gin"
 	"github.com/shiningrush/droplet"
+	"github.com/shiningrush/droplet/data"
 	wgin "github.com/shiningrush/droplet/wrapper/gin"
 
+	"github.com/apisix/manager-api/internal/core/entity"
+	"github.com/apisix/manager-api/internal/core/store"
 	"github.com/apisix/manager-api/internal/handler"
 	"github.com/apisix/manager-api/internal/utils"
 )
 
 type Handler struct {
+	serverInfoStore store.Interface
 }
 
 type InfoOutput struct {
 	Hash    string `json:"commit_hash"`
 	Version string `json:"version"`
 }
 
+type nodes struct {
+	Hostname string `json:"hostname"`
+	Version  string `json:"version"`
+}
+
+type VersionMatchOutput struct {
+	Matched          bool    `json:"matched"`
+	DashboardVersion string  `json:"dashboard_version"`
+	NotMatchedNodes  []nodes `json:"not_matched_nodes"`

Review comment:
       Good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570735124



##########
File path: api/internal/utils/consts/versionMap.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package consts
+
+/*
+	Key is dashboard version
+	Val is apisix version
+*/
+var VersionMap = map[string]string{

Review comment:
       Shall we use `const` to define the `VersionMap` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773490252


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=h1) Report
   > Merging [#1430](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=desc) (92efdd7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bad159bfb36596ad44a8df918320814f346c1697?el=desc) (bad159b) will **increase** coverage by `0.35%`.
   > The diff coverage is `71.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1430/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1430      +/-   ##
   ==========================================
   + Coverage   45.24%   45.59%   +0.35%     
   ==========================================
     Files          37       37              
     Lines        2524     2555      +31     
   ==========================================
   + Hits         1142     1165      +23     
   - Misses       1217     1224       +7     
   - Partials      165      166       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1430/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `45.88% <0.00%> (-1.68%)` | :arrow_down: |
   | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1430/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `80.00% <79.31%> (+8.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=footer). Last update [bad159b...92efdd7](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773805734


   need more members to review this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570677576



##########
File path: api/internal/handler/tool/tool.go
##########
@@ -48,3 +68,44 @@ func (h *Handler) Version(_ droplet.Context) (interface{}, error) {
 		Version: version,
 	}, nil
 }
+
+func (h *Handler) VersionMatch(c droplet.Context) (interface{}, error) {
+	_, version := utils.GetHashAndVersion()
+	var output VersionMatchOutput
+	output.DashboardVersion = version
+
+	matchedVersion := utils.GetMatchedVersion(version)
+
+	var notMatchedNodes = make([]nodes, 0)
+	_, err := h.serverInfoStore.List(c.Context(), store.ListInput{
+		Predicate: func(obj interface{}) bool {
+			serverInfo := obj.(*entity.ServerInfo)
+
+			if serverInfo.Version != matchedVersion {
+				notMatchedNodes = append(notMatchedNodes, nodes{
+					Hostname: serverInfo.Hostname,
+					Version:  serverInfo.Version,
+				})
+			}
+			return false
+		},
+	})
+
+	if err != nil {
+		return nil, err
+	}
+
+	output.NotMatchedNodes = notMatchedNodes
+	if len(output.NotMatchedNodes) == 0 {
+		output.Matched = true
+	} else {
+		// TODO: move this to utils
+		return &data.SpecCodeResponse{StatusCode: http.StatusOK, Response: data.Response{
+			Data:    &output,
+			Code:    2000001,
+			Message: "The version of manager-api and apisix are not matched.",

Review comment:
       ```suggestion
   			Message: "The manager-api and apache apisix are mismatched.",
   ```

##########
File path: api/internal/handler/tool/tool.go
##########
@@ -17,28 +17,48 @@
 package tool
 
 import (
+	"net/http"
+
 	"github.com/gin-gonic/gin"
 	"github.com/shiningrush/droplet"
+	"github.com/shiningrush/droplet/data"
 	wgin "github.com/shiningrush/droplet/wrapper/gin"
 
+	"github.com/apisix/manager-api/internal/core/entity"
+	"github.com/apisix/manager-api/internal/core/store"
 	"github.com/apisix/manager-api/internal/handler"
 	"github.com/apisix/manager-api/internal/utils"
 )
 
 type Handler struct {
+	serverInfoStore store.Interface
 }
 
 type InfoOutput struct {
 	Hash    string `json:"commit_hash"`
 	Version string `json:"version"`
 }
 
+type nodes struct {
+	Hostname string `json:"hostname"`
+	Version  string `json:"version"`
+}
+
+type VersionMatchOutput struct {
+	Matched          bool    `json:"matched"`
+	DashboardVersion string  `json:"dashboard_version"`
+	NotMatchedNodes  []nodes `json:"not_matched_nodes"`

Review comment:
       recommend using `mismatched_nodes` 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570735124



##########
File path: api/internal/utils/consts/versionMap.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package consts
+
+/*
+	Key is dashboard version
+	Val is apisix version
+*/
+var VersionMap = map[string]string{

Review comment:
       Shall we use `const` to define the `VersionMap` here?

##########
File path: api/internal/utils/consts/versionMap.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package consts
+
+/*
+	Key is dashboard version
+	Val is apisix version
+*/
+var VersionMap = map[string]string{

Review comment:
       Wow, my bad. Sorry.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz merged pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
starsz merged pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570739032



##########
File path: api/internal/utils/consts/versionMap.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package consts
+
+/*
+	Key is dashboard version
+	Val is apisix version
+*/
+var VersionMap = map[string]string{

Review comment:
       Wow, my bad. Sorry.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773812399


   > /lgtm
   
   Thank you for your code review. 😄


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#discussion_r570707626



##########
File path: api/internal/handler/tool/tool.go
##########
@@ -17,28 +17,48 @@
 package tool
 
 import (
+	"net/http"
+
 	"github.com/gin-gonic/gin"
 	"github.com/shiningrush/droplet"
+	"github.com/shiningrush/droplet/data"
 	wgin "github.com/shiningrush/droplet/wrapper/gin"
 
+	"github.com/apisix/manager-api/internal/core/entity"
+	"github.com/apisix/manager-api/internal/core/store"
 	"github.com/apisix/manager-api/internal/handler"
 	"github.com/apisix/manager-api/internal/utils"
 )
 
 type Handler struct {
+	serverInfoStore store.Interface
 }
 
 type InfoOutput struct {
 	Hash    string `json:"commit_hash"`
 	Version string `json:"version"`
 }
 
+type nodes struct {
+	Hostname string `json:"hostname"`
+	Version  string `json:"version"`
+}
+
+type VersionMatchOutput struct {
+	Matched          bool    `json:"matched"`
+	DashboardVersion string  `json:"dashboard_version"`
+	NotMatchedNodes  []nodes `json:"not_matched_nodes"`

Review comment:
       Good idea.

##########
File path: api/internal/utils/consts/versionMap.go
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package consts
+
+/*
+	Key is dashboard version
+	Val is apisix version
+*/
+var VersionMap = map[string]string{

Review comment:
       Sorry. We can't. Because of `const` type only for boolean, number, string.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz merged pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
starsz merged pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1430: feat: add version match API

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1430:
URL: https://github.com/apache/apisix-dashboard/pull/1430#issuecomment-773490252


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=h1) Report
   > Merging [#1430](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=desc) (92efdd7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bad159bfb36596ad44a8df918320814f346c1697?el=desc) (bad159b) will **increase** coverage by `0.35%`.
   > The diff coverage is `71.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1430/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1430      +/-   ##
   ==========================================
   + Coverage   45.24%   45.59%   +0.35%     
   ==========================================
     Files          37       37              
     Lines        2524     2555      +31     
   ==========================================
   + Hits         1142     1165      +23     
   - Misses       1217     1224       +7     
   - Partials      165      166       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1430/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `45.88% <0.00%> (-1.68%)` | :arrow_down: |
   | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1430/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `80.00% <79.31%> (+8.57%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=footer). Last update [bad159b...92efdd7](https://codecov.io/gh/apache/apisix-dashboard/pull/1430?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org