[jira] Closed: (GERONIMO-4542) Significant lock contention exists in HttpServletResponse.addCookie()

["Shawn Jiang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GERONIMO-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang closed GERONIMO-4542.
---------------------------------

    Resolution: Fixed

After upgrading to tomcat 6.0.20, this has been resolved.

See:
https://svn.apache.org/repos/asf/geronimo/external/trunk/tomcat-parent-6.0.20/util/src/main/java/org/apache/tomcat/util/http/ServerCookie.java

> Significant lock contention exists in HttpServletResponse.addCookie() 
> ----------------------------------------------------------------------
>
>                 Key: GERONIMO-4542
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-4542
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Tomcat
>    Affects Versions: 2.0, 2.0.1, 2.0.2, 2.0.3, 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.2
>         Environment: All
>            Reporter: Manu T George
>            Assignee: Shawn Jiang
>
> org.apache.catalina.connector.Response
> calls ServerCookie.appendCookieValue which in turn calls
> DateTool.formatOldCookie in tomcat6 which contains synchronisation which results in significant contention. The fix will be to use a ThreadLocal variable instead. 
> The code change can be found in tomcat trunk
> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?view=markup&pathrev=744564
> http://svn.apache.org/viewvc?view=rev&revision=744238

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.