You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/04 06:43:39 UTC
[GitHub] [incubator-tvm] yuliujq opened a new pull request #4620: fskip of
EliminateCommonSubexpr will not always return false
yuliujq opened a new pull request #4620: fskip of EliminateCommonSubexpr will not always return false
URL: https://github.com/apache/incubator-tvm/pull/4620
Originally, fskip returns false at the end of PackedFunc, discards return true in 'cast' case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yuliujq closed pull request #4620: [Bugfix] fskip
of EliminateCommonSubexpr cannot always return false
Posted by GitBox <gi...@apache.org>.
yuliujq closed pull request #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yuliujq commented on a change in pull request
#4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
Posted by GitBox <gi...@apache.org>.
yuliujq commented on a change in pull request #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620#discussion_r363659261
##########
File path: src/relay/backend/build_module.cc
##########
@@ -318,6 +318,7 @@ class RelayBuildModule : public runtime::ModuleNode {
pass_seqs.push_back(transform::SimplifyInference());
PackedFunc fskip = PackedFunc([](TVMArgs args, TVMRetValue* rv) {
Expr expr = args[0];
+ *rv = false;
Review comment:
Default return false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yuliujq opened a new pull request #4620: [Bugfix]
fskip of EliminateCommonSubexpr cannot always return false
Posted by GitBox <gi...@apache.org>.
yuliujq opened a new pull request #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620
Originally, fskip returns false at the end of PackedFunc, discards return true in 'cast' case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu commented on issue #4620: [Bugfix] fskip of
EliminateCommonSubexpr cannot always return false
Posted by GitBox <gi...@apache.org>.
yzhliu commented on issue #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620#issuecomment-570992301
also can we have a test case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 merged pull request #4620: [Bugfix] fskip of
EliminateCommonSubexpr cannot always return false
Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yuliujq commented on issue #4620: [Bugfix] fskip of
EliminateCommonSubexpr cannot always return false
Posted by GitBox <gi...@apache.org>.
yuliujq commented on issue #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620#issuecomment-570762357
A little fix for fskip in EliminateCommonSubexpr, it will not return false in 'cast' case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 commented on issue #4620: [Bugfix] fskip of
EliminateCommonSubexpr cannot always return false
Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #4620: [Bugfix] fskip of EliminateCommonSubexpr cannot always return false
URL: https://github.com/apache/incubator-tvm/pull/4620#issuecomment-570903682
could you take a look at the ci error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services