You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/07 03:28:33 UTC
[GitHub] [flink] danny0405 commented on a change in pull request #10469:
[FLINK-15107][SQL-CLIENT]Fix bug that sql cli can not execute statement
with lower 'inert into'
danny0405 commented on a change in pull request #10469: [FLINK-15107][SQL-CLIENT]Fix bug that sql cli can not execute statement with lower 'inert into'
URL: https://github.com/apache/flink/pull/10469#discussion_r355096643
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java
##########
@@ -108,6 +109,11 @@
private final ResultStore resultStore;
+ // insert into sql match pattern
+ private static final int DEFAULT_PATTERN_FLAGS = Pattern.CASE_INSENSITIVE | Pattern.DOTALL;
+ public static final Pattern INSERT_INTO_SQL_PATTERN = Pattern.compile("(INSERT\\s+INTO.*)",
+ DEFAULT_PATTERN_FLAGS);
+
Review comment:
We can inline this `DEFAULT_PATTERN_FLAGS ` directly to avoid introduce a new variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services