You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/11/22 12:12:50 UTC
[GitHub] [httpcomponents-client] nielsbasjes opened a new pull request #174:
HTTPCLIENT-2030: Fix PublicSuffixMatcher::getDomainRoot on invalid hostnames
nielsbasjes opened a new pull request #174: HTTPCLIENT-2030: Fix PublicSuffixMatcher::getDomainRoot on invalid hostnames
URL: https://github.com/apache/httpcomponents-client/pull/174
This fixes the behaviour of PublicSuffixMatcher::getDomainRoot in the case when you feed it a hostname for which NO rule has been defined; and you specify an expected domaintype (i.e. either ICANN or PRIVATE).
Notable changes for reviewers:
- PublicSuffixMatcher load(final InputStream in) is now public to make testing a lot easier and also useful for downstream users.
- I had to change the test for HTTPCLIENT-1997 also because that used an invalid domain name in their test. So instead of "cloud.a" it now uses "cloud.com" instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org