You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by bu...@apache.org on 2005/12/14 18:08:39 UTC

DO NOT REPLY [Bug 37910] New: - Parameter check in ByteArrayOutputStream should be narrowed

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37910>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37910

           Summary: Parameter check in ByteArrayOutputStream should be
                    narrowed
           Product: Commons
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P4
         Component: IO
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: morisil@ncdc.pl


In class org.apache.commons.io.output.ByteArrayOutputStream the write(byte[] b,
int off, int len) method has the following check:

        if ((off < 0) 
                || (off > b.length) 
                || (len < 0) 
                || ((off + len) > b.length) 
                || ((off + len) < 0)) {

The (off > b.length) check should be replaced with (off >= b.length). In the
current code incorrect offset (equal to b.lenght) can be specified if the len
parameter is set to 0.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org