[GitHub] [accumulo] milleruntime commented on a diff in pull request #2755: Fix Fate print command and improve ShellServerIT test

[GitBox <gi...@apache.org>]

milleruntime commented on code in PR #2755:
URL: https://github.com/apache/accumulo/pull/2755#discussion_r902969741


##########
core/src/main/java/org/apache/accumulo/fate/AdminUtil.java:
##########
@@ -390,17 +388,23 @@ private FateStatus getTransactionStatus(ReadOnlyTStore<T> zs, Set<Long> filterTx
 
       zs.unreserve(tid, 0);
 
-      if ((filterTxid != null && !filterTxid.contains(tid))
-          || (filterStatus != null && !filterStatus.contains(status)))
-        continue;
-
-      statuses.add(new TransactionStatus(tid, status, debug, hlocks, wlocks, top, timeCreated));
+      if (includeByStatus(status, filterStatus) && includeByTxid(tid, filterTxid)) {

Review Comment:
   So if the user doesn't specify a TXID, will they get any results back for just a status? I think we may have talked about this but the AND here makes it seem like you need both to get anything back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org