[GitHub] [incubator-echarts] 100pah commented on a change in pull request #11951: feat(bar): bar background

[GitBox <gi...@apache.org>]

100pah commented on a change in pull request #11951: feat(bar): bar background
URL: https://github.com/apache/incubator-echarts/pull/11951#discussion_r363791042
 
 

 ##########
 File path: src/chart/bar/BarSeries.js
 ##########
 @@ -57,6 +57,20 @@ export default BaseBarSeries.extend({
 
         // If use caps on two sides of bars
         // Only available on tangential polar bar
-        roundCap: false
+        roundCap: false,
+
+        showBackground: false,
+        backgroundStyle: {
+            color: 'rgba(180, 180, 180, 0.2)',
+            borderColor: null,
+            borderWidth: '0',
+            borderType: 'solid',
+            barBorderRadius: 0,
+            shadowBlur: 0,
+            shadowColor: '',
 
 Review comment:
   (I am not sure) 
   By convention it uses `null`/`undefined` to represent "no color" rather than `''`.
   Somewhere it might be determined by `xxx == null`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org