[GitHub] [flink] sv3ndk commented on a change in pull request #14601: [FLINK-20907][docs] replaces deprecated syntax in Table API doc

[GitBox <gi...@apache.org>]

sv3ndk commented on a change in pull request #14601:
URL: https://github.com/apache/flink/pull/14601#discussion_r554598681



##########
File path: docs/dev/table/common.md
##########
@@ -51,18 +51,18 @@ All Table API and SQL programs for batch and streaming follow the same pattern.
 // create a TableEnvironment for specific planner batch or streaming
 TableEnvironment tableEnv = ...; // see "Create a TableEnvironment" section
 
-// create a Table
-tableEnv.connect(...).createTemporaryTable("table1");
+// create an input Table
+tableEnv.executeSql("CREATE TEMPORARY TABLE table1 ... with ( 'connector' = ... )");
 // register an output Table
-tableEnv.connect(...).createTemporaryTable("outputTable");
+tableEnv.executeSql("CREATE TEMPORARY TABLE outputTable ... with ( 'connector' = ... )");

Review comment:
       Yes, good point, thanks for the feedback. 
   Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org