[jira] [Closed] (DBCP-547) Add a ConnectionFactory class name setting for BasicDataSource.createConnectionFactory() #33

["Gary Gregory (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Gregory closed DBCP-547.
-----------------------------
    Resolution: Fixed

> Add a ConnectionFactory class name setting for BasicDataSource.createConnectionFactory() #33
> --------------------------------------------------------------------------------------------
>
>                 Key: DBCP-547
>                 URL: https://issues.apache.org/jira/browse/DBCP-547
>             Project: Commons DBCP
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Lee Jun Gyun
>            Priority: Minor
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> It think it would be nice better to implement a ConnectionFactory class name setting in BasicDataSource class or implement a interface in DriverConnectionFactory class.
> In my current project, when getting a connection in my program, I call oracleSetModule.
> so, i think that after creating connection, call oracleSetModule via connectionFactoryImpl seems to be nice.
>   
> [Before]
> protected ConnectionFactory createConnectionFactory() throws SQLException {
> ...
> ...
> ConnectionFactory driverConnectionFactory =
>  new DriverConnectionFactory(driverToUse, url, connectionProperties);
>  return driverConnectionFactory;
>  }
> [After]
> protected ConnectionFactory createConnectionFactory() throws SQLException {
> ...
> ...
> ConnectionFactory driverConnectionFactory =
> getConnectionFactoryImpl().newInstance(...);
> return driverConnectionFactory;
> }
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)