You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/20 02:34:30 UTC
[GitHub] [pulsar] rmn36 opened a new pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
rmn36 opened a new pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855
Fixes #7846
### Motivation
Given a wildcard in a tenant or namespace I would expect the code to look up all tenants/namespaces that match and then lookup all topics to subscribe to.
### Verifying this change
- Updated PatternMultiTopicsConsumerImplTest
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (**yes** / no)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (**yes** / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-728645156
move to 2.8.0 first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-903371689
Hi @rmn36 any progress for the code and doc? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-691588061
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-689533122
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-691627434
@rmn36 Seems some of the error in ci is related to this change.
e.g. cpp ci test:
```
/pulsar/pulsar-client-cpp/lib/Commands.cc: In static member function 'static std::__cxx11::string pulsar::Commands::messageType(pulsar::proto::BaseCommand_Type)':
/pulsar/pulsar-client-cpp/lib/Commands.cc:464:12: error: enumeration value 'BaseCommand_Type_GET_NAMESPACES_BY_REGEX' not handled in switch [-Werror=switch]
switch (type) {
^
/pulsar/pulsar-client-cpp/lib/Commands.cc:464:12: error: enumeration value 'BaseCommand_Type_GET_NAMESPACES_BY_REGEX_RESPONSE' not handled in switch [-Werror=switch]
[ 9%] Building CXX object lib/CMakeFiles/pulsarStatic.dir/ClientConnection.cc.o
[ 9%] Building CXX object lib/CMakeFiles/pulsarStatic.dir/TopicName.cc.o
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] siaron commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
siaron commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-922235670
Is there any update? We really need this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-721698923
@rmn36 Would you please help resolve the conflicts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#discussion_r474054814
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
##########
@@ -30,17 +30,12 @@
import java.lang.reflect.Field;
import java.net.URI;
import java.net.URL;
-import java.util.Collections;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
Review comment:
Please avoid using ".*"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-717055579
@rmn36 Would you please help rebase the code with master, and get the ci fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet edited a comment on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-793367678
@rmn36 thanks for your work.
1. Any progress for this PR?
2. Could you please help add docs accordingly? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-816482072
@rmn36 thanks for your work.
1. Any progress for this PR?
2. Could you please help add docs accordingly? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #7855:
URL: https://github.com/apache/pulsar/pull/7855#issuecomment-793367678
@rmn36 thanks for your great work. Could you please help add docs accordingly? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org